New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 116745 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Windows 8 Metro snap breaks tabs on CP

Reported by dwh...@thetrueaplus.com, Mar 4 2012

Issue description

Chrome Version       : 17.0.963.56 (Official Build 121963) m
URLs (if applicable) : N/A
Other browsers tested: N/A
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. Metro snap an app to the side when chrome is maximized
2. Close the metro snap.
3. The tabs in chrome disappear.

What is the expected result?
The tabs remain.

What happens instead?
The non-client area doesn't draw the tabs.


Please provide any additional information below. Attach a screenshot if
possible.
 

Comment 1 by cpu@chromium.org, Mar 16 2012

Labels: Hotlist-Windows8

Comment 2 by Deleted ...@, Mar 28 2012

A screenshot as requested
chrome error.PNG
140 KB View Download
Cc: robertshield@chromium.org grt@chromium.org
Owner: cpu@chromium.org
Assigning to Carlos.
Cc: ananta@chromium.org
Labels: -Area-Undefined Area-UI
Carlos, Ananta (newly cc'ing you) - any ideas about this?

Comment 6 by vekto...@gmail.com, Jun 11 2012

I confirm that this issue happens. I just tested it again with Windows 8 CP (64 Bit) and with Chrome 20.0.1132.27 beta-m. After the bug appears and all Chrome tabs disapearing, you just have to press control + t to open a new tab. Then, all tabs are appearing again and everything is fine :-)
Thanks for the confirmation, vektoren. Carlos, have you had a chance to take a look at this at all?

Comment 8 by cpu@chromium.org, Jun 15 2012

Cc: joi@chromium.org
I can repro as well. Scott has no idea. I'll try to troubleshoot this soon.

If somebody wants to have a crack at this let me know.

Comment 9 by cpu@chromium.org, Jun 19 2012

Labels: -Pri-2 Pri-1
Owner: ananta@chromium.org
Ananta is looking at this.
Status: Assigned
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143447

------------------------------------------------------------------------
r143447 | ananta@chromium.org | Thu Jun 21 13:46:38 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame_win.cc?r1=143447&r2=143446&pathrev=143447
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame_win.h?r1=143447&r2=143446&pathrev=143447

On Windows 8 when a metro application is snapped running desktop application windows are resized as
the workarea is reduced. Desktop chrome fails to paint the tabstrip when we receive this resize notification.

Reason: The WM_GETTITLEBARINFOEX message we send to calculate the minimize button offset in the caption, fails
        if we are not active.

Fix is to calculate and cache the delta of the minimize button which is applied to the left/right edge of the
client rect if we fail to get the minimize button offset.

BUG= 116745 
R=sky
Review URL: https://chromiumcodereview.appspot.com/10596005
------------------------------------------------------------------------
Labels: ReleaseBlock-Beta Merge-Requested

Comment 13 by kareng@google.com, Jun 22 2012

Labels: Mstone-21
we'll merge tomorrow if it looks good.

Comment 14 by kareng@google.com, Jun 22 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 22 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143636

------------------------------------------------------------------------
r143636 | ananta@chromium.org | Fri Jun 22 10:52:09 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/frame/browser_frame_win.h?r1=143636&r2=143635&pathrev=143636
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/frame/browser_frame_win.cc?r1=143636&r2=143635&pathrev=143636

Merge 143447 - On Windows 8 when a metro application is snapped running desktop application windows are resized as
the workarea is reduced. Desktop chrome fails to paint the tabstrip when we receive this resize notification.

Reason: The WM_GETTITLEBARINFOEX message we send to calculate the minimize button offset in the caption, fails
        if we are not active.

Fix is to calculate and cache the delta of the minimize button which is applied to the left/right edge of the
client rect if we fail to get the minimize button offset.

BUG= 116745 
R=sky
Review URL: https://chromiumcodereview.appspot.com/10596005

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10638016
------------------------------------------------------------------------

Comment 16 by kareng@google.com, Jun 22 2012

can i l close this?
I believe so! This is fixed, right, Ananta?

Comment 18 by kareng@google.com, Jun 22 2012

Status: Fixed
Tabs are still broken for me on 21.0.1180.11.
Metro snap.png
382 KB View Download
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-21 M-21 Cr-UI
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment