Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 116603 Flashes when switching between composited and non-composited mode
Starred by 4 users Project Member Reported by vangelis@google.com, Mar 2, 2012 Back to list
Status: Fixed
Owner: apatrick@chromium.org
Closed: Mar 2012
Cc: nduca@chromium.org, jam...@chromium.org, apatrick@chromium.org
Components:
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Version: 19.0.1058.0
OS: Win7

What steps will reproduce the problem?
1. Go to Google.com and search for html5 video 
2. Click on the first link (html5video.org). Notice how the page flashes a few times before it settles (if you enable the debug layer borders you'll see them coming in and out too).
3. Go back to the search results, click on "HTML5 Rocks - HTML5 Video". The first flash now displays the contents of the html5video.org page. 
4. If you go back through the search results page and to the other link, you'll see a flash of the previous page.

Running chrome with --disable-image-transport-surface --no-sandbox doesn't eliminate the flash but makes it so that you don't see the results of the previous tab. 

Maybe a fallout from memory manager / visibility changes?  Possibly also related to issue 115991


I cannot repro on the mac.  Haven't tried linux yet.


 
Comment 1 by vangelis@google.com, Mar 2, 2012
Bisected to: 

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=113758:113768

http://trac.webkit.org/log/trunk/?rev=102341&stop_rev=102380&verbose=on
(although there doesn't appear to be anything useful in the webkit range).

The obvious suspect is: http://src.chromium.org/viewvc/chrome?view=rev&revision=113761

but that doesn't explain why disabling the image transport surface eliminates the issue.



Comment 2 by vangelis@google.com, Mar 2, 2012
I tried version 114341 that's the first build where the --disable-image-transport-surface flag works and is after the flashing issues started.  With image-transport-surface disabled, I don't see the flash.  So the later flashes in canary could be yet a different issue.

I think it might be this part of r113761 then:

"Also implemented PbufferImageTransportSurface::SetVisible by making the underlying surface 1x1 when it is not visible."

If the surface is made visible from having been invisible and then presented without rendering a frame into it first, it'll flash. The flash of the wrong tab contents in later versions might be because the newly visible surface contains uninitialized data.
Comment 4 by vangelis@google.com, Mar 6, 2012
Cc: -mmo...@chromium.org
Labels: -Pri-2 -mstone-19 -ReleaseBlock-Beta Pri-1 Mstone-18 ReleaseBlock-Stable
Owner: apatrick@chromium.org
Status: Assigned
The flashing is bad enough that I think it should be fixed before we ship to stable.
Status: Started
Fix pending review.
https://chromiumcodereview.appspot.com/9615042/

To merge to 18 I'll need to first merge a subset of r119979, the two accelerated_surface_win files.
Project Member Comment 6 by bugdroid1@chromium.org, Mar 7, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=125303

------------------------------------------------------------------------
r125303 | apatrick@chromium.org | Tue Mar 06 18:44:34 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=125303&r2=125302&pathrev=125303

Drop accelerated surface when switching off accelerated compositor.

Otherwise when the accelerated compositor is next activated, a flash of the last accelerated composited page will appear.

BUG= 116603 

Review URL: http://codereview.chromium.org/9615042
------------------------------------------------------------------------
Labels: OS-Windows Merge-Requested
Tested patch in #6 using Canary 19.0.1062.0 with repro steps in #1. It seems to be fixed.
Comment 8 by kareng@google.com, Mar 7, 2012
Labels: -Merge-Requested Merge-Approved
Project Member Comment 9 by bugdroid1@chromium.org, Mar 7, 2012
Labels: -merge-approved merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=125454

------------------------------------------------------------------------
r125454 | apatrick@chromium.org | Wed Mar 07 13:18:15 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=125454&r2=125453&pathrev=125454

Merge 125303 - Drop accelerated surface when switching off accelerated compositor.

Otherwise when the accelerated compositor is next activated, a flash of the last accelerated composited page will appear.

BUG= 116603 

Review URL: http://codereview.chromium.org/9615042

TBR=apatrick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9620019
------------------------------------------------------------------------
Comment 10 by kareng@google.com, Mar 9, 2012
Status: Fixed
Project Member Comment 11 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 12 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-Internals -feature-gpu -Mstone-18 Cr-Internals-GPU M-18 Cr-Internals
Project Member Comment 13 by bugdroid1@chromium.org, Mar 13, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment