New issue
Advanced search Search tips
Starred by 162 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Chromium doesn't take into account the XShape of windows when dragging tabs (cannot merge a tab back into a window)

Reported by mic...@sawicz.net, Feb 20 2012 Back to list

Issue description

Chromium doesn't take into account the XShape of windows when dragging tabs

Chrome Version       : 17.0.963.56 (Developer Build 121963)
OS Version: Ubuntu 12.04 in "Ubuntu 2D" session

What steps will reproduce the problem?
1. drag a tab within a Chromium window or from one Chromium window to another

What is the expected result?
* You're able to rearrange the tabs or move them between windows.

What happens instead?
* For every tab dragged a new Chromium window is created.

Please provide any additional information below. Attach a screenshot if
possible.

The Ubuntu 2D session uses a shell whose window is fullscreen but XShaped (see http://www.x.org/releases/X11R7.6/doc/libXext/shapelib.html) to only cover expected parts of the screen. It seems that when dragging tabs, Chromium doesn't query the X server for the XShape of the window and that results in it thinking the tab was dragged outside of its own window and opens a new window with that tab when dropped.
 
I can confirm this issue on the current stable release of Ubuntu 12.04 LTS.

Chrome Version: 18.0.1025.162
OS Verision: Ubuntu 12.04 LTS in "Unity 2D" session
Labels: -Area-Undefined Area-UI Feature-TabStrip

Comment 3 by pjdelp...@gmail.com, Jun 13 2012

Related / duplicates issues:

*  issue #122789 
*  issue #124761 
Cc: e...@chromium.org est...@chromium.org
 Issue 124761  has been merged into this issue.
 Issue 122789  has been merged into this issue.

Comment 6 by dhw@chromium.org, Sep 4 2012

Labels: Feature-OSIntegration
Status: Untriaged
Summary: Chromium doesn't take into account the XShape of windows when dragging tabs (cannot merge a tab back into a window)

Comment 7 by jam...@chromium.org, Sep 24 2012

 Issue 124761  has been merged into this issue.

Comment 8 by myad...@gmail.com, Sep 27 2012

I believe this issue may be related to metacity.
Open a terminal and type "killall metacity". You wont have windows any more but suddenly chrome can attach and detach tabs again.
I can confirm that this workaround works, although I'm quite surprised. Chromium seems to be completely un-phased by the lack of a window manager.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159111

------------------------------------------------------------------------
r159111 | jamesr@chromium.org | 2012-09-27T20:53:51.646168Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/x/x11_util.cc?r1=159111&r2=159110&pathrev=159111
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/x/x11_util.h?r1=159111&r2=159110&pathrev=159111
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc?r1=159111&r2=159110&pathrev=159111
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dock_info_gtk.cc?r1=159111&r2=159110&pathrev=159111

Fix tab dragging in unity2d

Unity 2d creates non-rectangled or 'shaped' X11 windows. These windows have a
big bounding box according to XGetGeometry but should actually only interact
with part of the screen, which confuses the tab strip dragging code. This
checks if a point is actually inside the ShapeInput list when this extension
is supported by the X display

BUG= 114985 


Review URL: https://chromiumcodereview.appspot.com/10990010
------------------------------------------------------------------------
Status: Fixed
Should be fixed now.  If anyone is still seeing this issue, please confirm that you are on r159111 or newer (version string should start with "24...", not "23...") and post your exact version string and desktop environment here.

Comment 12 by dhw@chromium.org, Sep 28 2012

Cc: manoranj...@chromium.org
 Issue 152762  has been merged into this issue.
 Issue 146266  has been merged into this issue.

Comment 14 by dhw@chromium.org, Oct 16 2012

 Issue 156053  has been merged into this issue.

Comment 15 by b...@yelp.com, Oct 16 2012

@jamesr What's the easiest way for us to get that version?

Comment 17 by jennb@chromium.org, Nov 15 2012

I'm still seeing this problem.

Google Chrome	24.0.1312.5 (Official Build 166104) beta
OS	Linux 

Using Unity2D.
@jennb - could you be a bit more specific?  What distro of linux?  What is the symptom you are seeing?  Do you have a multi-monitor setup?

Comment 19 by takig...@gmail.com, Nov 15 2012

@jamesr - i likewise have the same issue still. 24.0.1312.5-r166104 beta using unity 2d on ubuntu 12.04. Dual-monitor with intel i915. Cant drag tabs back into a chrome window once they have been taken out.

Though, i assumed this hadnt been released into beta channel yet (where my browser is coming from, but its the same version as jennb is using).
Could you re-open this? I also started experiencing the same issue:

Ubuntu 12.04
Chrome Version 24.0.1312.14
Unity 2D
Please open a new bug - chrome *does* take the window's XShape into account (although perhaps not correctly), so the bug you are seeing may or may not be the same issue.  I'm not going to be able to look into this.

Comment 22 by ke...@fidelma.com, Nov 29 2012

Although it was stated (comment 17) that "Should be fixed now" has anybody actually *seen* it work? 

The bug is "cannot merge a tab back into a window", and if that's still happening, and there's no evidence that it was ever fixed, then I don't see the point in raising a new bug.

How will the 162 people who are watching this bug (presumably because they'd be happy if it were fixed) know about the new bug? Will they automatically be notified when that bug is fixed?

Reopening this one seems reasonable to me.
I am running Chrome 24.0.1312.25 on Ubuntu 12.04 with Unity 3D and it now works. I can:
-- Drag tabs off to create a new window
-- Drag tabs back onto another window to add them back
-- Rearrange the order of tabs in the same window

Now if only I could get X11 to stop crashing under Unity...

Comment 24 by mvl@google.com, Nov 29 2012

I am also running  Chrome 24.0.1312.25 on Ubuntu 12.04 but am still experiencing this issue.  Any tabs dragged will break into a new window and will never rejoin.

Comment 25 by catel...@gmail.com, Nov 29 2012

Well, I've just tested on my two easily reachable Ubuntu 12.10 boxes and both of them seem to work with out of the box Chrome as well as Chromium. I obviously had this issue earlier since I starred this... (though I hardly ever use this feature myself - this was primarily a request from another family member - so I can't say when it started to work). One of my boxes use Gnome and the other Unity BTW.

Comment 26 by takig...@gmail.com, Nov 29 2012

likewise, 24.0.1312.25 on ubuntu 12.04 unity 2d, still wont re-join windows. I was under the impression this was always a unity 2d only bug?
Sorry you're right, this was an issue for me with Unity 2D as well, but I did see it working under Unity 2D with the latest Chrome.

I recently switched to 3D, sorry for the confusion.

Comment 28 Deleted

Comment 29 by nkj...@gmail.com, Dec 5 2012

I have the same issue.
It's very tricky to re-attach a tab after you detached.
But I do this:
-detach a tab, leave it detached for a second,
- drag it with the mouse,
- keep dragging and shake the mouse very very quickly near the tab bar you
sould re-attach in,
- magically it start re-attaching.

just my 2 cents.

Comment 30 by e...@chromium.org, Dec 5 2012

Cc: -e...@chromium.org
Labels: Restrict-AddIssueComment-Commit
I don't want to see people's comments about unfixed bugs get lost.  Commenting here is not going to do anything, so I'm closing comments on this bug to make it explicitly clear: if you are suffering from some problem, file a new bug.  As noted in comment 21, Chrome ought to be respecting the XShape, so continuing problems may be the result of another issue.
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-TabStrip -Feature-OSIntegration Cr-UI-OSIntegration Cr-UI-Browser-TabStrip Cr-UI
This may be related to  bug 319795 . Chrome needs to respect ShapeBounding rects in addition to ShapeInput. Draft CL at https://codereview.chromium.org/153953006/.
Components: -UI>OSIntegration Internals>PlatformIntegration

Sign in to add a comment