New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue v8-i18n:2
issue 114148

Blocking:
issue 2685
issue 138993



Sign in to add a comment
link

Issue 114805: Make an extension for font settings using a new font setting API

Reported by js...@chromium.org, Feb 17 2012 Project Member

Issue description

Once the API worked on in bug 114148 is added, we need to make an extension to allow users to control font preferences per script. 


That extension needs to display script names in the current locale. We don't have an extension API to retrieve display names for scripts. There are 3 alternatives to handle this:

1) An extension can have strings for script names and get them translated. Can be done right now, but it's kinda waste because Chrome already has ICU/CLDR data with all these names
2) Add an extension API to retrieve display names for scripts (languages and country). lang/country is not necessary for font API, but other extensions may find it useful
3) Add a JavaScript API for that. 

#3 was actually a part of the initial JavaScript I18N API proposal, but it's removed because other parties can support that. However, we can add a vendor-prefixed API.  See http://code.google.com/p/v8-i18n/issues/detail?id=2

I think #3 is the best, which is why I filed that bug against v8-i18n project.
 

Comment 1 by js...@chromium.org, Feb 17 2012

Blocking: 2685

Comment 2 by js...@chromium.org, Feb 17 2012

Blockedon: 114148
Labels: Mstone-19
Status: Available
Mstone-19 is a bit aggressive, but we can try.

Comment 3 by js...@chromium.org, Feb 17 2012

Blockedon: v8-i18n:2

Comment 4 by falken@chromium.org, Mar 7 2012

The example extension at chrome/common/extensions/docs/examples/api/fontSettings/ (http://crrev.com/125293) is usable but only in English.

Comment 5 by laforge@google.com, Mar 27 2012

Labels: -Mstone-19 Mstone-20 MovedFrom-19

Comment 6 by dharani@google.com, May 8 2012

Labels: -Mstone-20 MovedFrom-20 Mstone-21
M20 has sailed. If this need to be part of M20, please put the Mstone-20 label back along with release block tag.

Comment 7 by karen@chromium.org, Jul 11 2012

Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone

Comment 8 by js...@chromium.org, Jul 11 2012

@falken, should we publish the example extension at Chrome web store? 

BTW, we also need to add an API to control the minimum font size for each script.

Comment 9 by falken@chromium.org, Jul 19 2012

I think it's ok to publish the example extension in the web store. Of course we'll have to wait for the API to move out of experimental and then hit the stable channel. I plan to move out of experimental in M22. (I have a CL under review now.)

 issue 17078  tracks adding per-script min font size settings.

Comment 10 by bugdroid1@chromium.org, Aug 9 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=150759

------------------------------------------------------------------------
r150759 | falken@chromium.org | 2012-08-09T06:48:46.782430Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json?r1=150759&r2=150758&pathrev=150759
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.html?r1=150759&r2=150758&pathrev=150759
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/popup.js?r1=150759&r2=150758&pathrev=150759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=150759&r2=150758&pathrev=150759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings.zip?r1=150759&r2=150758&pathrev=150759
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.js?r1=150759&r2=150758&pathrev=150759
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/popup.html?r1=150759&r2=150758&pathrev=150759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/extensions/samples.html?r1=150759&r2=150758&pathrev=150759

Change Font Settings Sample Extension to use an options page instead of browser action.

As suggested by UI leads. The goal is to put the sample extension in the Web Store, but it
must be polished up a little first.

BUG= 114805 
TBR=mpcomplete

Review URL: https://chromiumcodereview.appspot.com/10834241
------------------------------------------------------------------------

Comment 11 by falken@chromium.org, Aug 14 2012

Cc: js...@chromium.org
 Issue 142130  has been merged into this issue.

Comment 12 by falken@chromium.org, Aug 14 2012

Blocking: chromium:138993

Comment 13 by falken@chromium.org, Aug 14 2012

Cc: glen@chromium.org
 Issue 142130  has been merged into this issue.

Comment 14 by bugdroid1@chromium.org, Sep 4 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=154729

------------------------------------------------------------------------
r154729 | falken@chromium.org | 2012-09-04T06:58:39.318998Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.html?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/chrome_shared.css?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/uber_shared.css?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/widgets.css?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/images?r1=154729&r2=154728&pathrev=154729
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.js?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/images/select.png?r1=154729&r2=154728&pathrev=154729
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css?r1=154729&r2=154728&pathrev=154729

Font Settings API: Use Chrome settings CSS in sample extension.

As suggested by UI leads, to polish the sample extension's UI.

BUG= 114805 
TBR=mpcomplete

Review URL: https://chromiumcodereview.appspot.com/10907052
------------------------------------------------------------------------

Comment 15 by bugdroid1@chromium.org, Sep 10 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=155675

------------------------------------------------------------------------
r155675 | falken@chromium.org | 2012-09-10T07:06:12.573237Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.html?r1=155675&r2=155674&pathrev=155675
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/widgets.css?r1=155675&r2=155674&pathrev=155675
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.js?r1=155675&r2=155674&pathrev=155675

Font Settings API: Sample Extension minor UI improvements

Use input type=number and let font size settings affect only the sample texts.

BUG= 114805 
TBR=mpcomplete


Review URL: https://chromiumcodereview.appspot.com/10908166
------------------------------------------------------------------------

Comment 16 by k...@google.com, Oct 2 2012

Blocking: -chromium:2685 chromium:2685
Labels: -Mstone-22 Mstone-24 MovedFrom-22
Moving out to M24, Please pull back in to previous milestones if needed.

Comment 17 by k...@google.com, Oct 2 2012

Moving out to M24, Please pull back in to previous milestones if needed.

Comment 18 by bugdroid1@chromium.org, Oct 22 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=163241

------------------------------------------------------------------------
r163241 | falken@chromium.org | 2012-10-22T08:36:28.013765Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui?r1=163241&r2=163240&pathrev=163241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.html?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/images/x.png?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/array_data_model.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/overlay.css?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_item.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/images/x-pressed.png?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/util.js?r1=163241&r2=163240&pathrev=163241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/options.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_selection_model.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_single_selection_model.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js?r1=163241&r2=163240&pathrev=163241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/manifest.json?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/images/x-hover.png?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/event_target.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/event_tracker.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/touch_handler.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/overlay.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/css/list.css?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr/ui/list_selection_controller.js?r1=163241&r2=163240&pathrev=163241
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/fontSettings/js/cr.js?r1=163241&r2=163240&pathrev=163241

Font Settings API: UI overhaul of example extension.

Based on suggestions from UI review and Marcin Wichary.
This change copies several files required to use the list and overlay/popup
widgets of Chrome.

BUG= 114805 
TBR=mpcomplete

Review URL: https://codereview.chromium.org/11227018
------------------------------------------------------------------------

Comment 19 by falken@chromium.org, Oct 25 2012

Owner: falken@chromium.org
Status: Fixed
An extension is available at:
https://chrome.google.com/webstore/detail/advanced-font-settings/caclkomlalccbpcdllchkeecicepbmbm
(and in the codebase under chrome/common/extensions/docs/examples/api/fontSettings/)

I'd like to close this bug and create new ones for specific issues with the extension.

Comment 20 by sungk...@gmail.com, Oct 25 2012

Sounds great - just a heads up: on Windows 8 64-bit with Chrome version 22.0.1229.94 m the Script/Language list cannot be seen (see screenshot).
Thanks for your work on this though - I am very excited to be able to change fonts (I hope) for the Khmer language once I can see the list of languages in the Script box.
Script-Change-Chrome.jpg
24.1 KB View Download

Comment 21 by sungk...@gmail.com, Oct 25 2012

Before commenting I had restarted Chrome once and the problem still persisted, but now I just restarted a second time and the box shows up. Still must be some sort of issue, but at least it works now. Thanks! Works great!

On another note - would it be possible to add the ability to change the tab title font (see screenshot)? The default font for Khmer in Windows is not that great (hard to read). Thank you!
tab-title-font.jpg
4.1 KB View Download

Comment 22 by falken@chromium.org, Oct 25 2012

sungkhum: Thanks for the feedback and sorry about the list sizing problems. I have also run into that occasionally and found that reloading the page usually fixes it. I've opened  bug 157879  to track this issue.

As for tab title fonts, I think right now the tab title font comes from the system UI on Windows. Relevant bugs are bug 17866,  bug 155922 ,  bug 136093 .

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-I18N -Mstone-24 Cr-UI M-24 Cr-UI-I18N

Comment 24 by bugdroid1@chromium.org, Mar 20 2013

Project Member
Labels: -Cr-UI-I18N Cr-UI-Internationalization

Comment 25 Deleted

Sign in to add a comment