Certain redirections remove sites from the history
Reported by prog...@gmail.com, May 2 2009
Chrome Version : 126.96.36.199 188.8.131.52 (15143) URL : http://www.neowin.net/news/main/09/05/01/google-being-sued-over-the- android-brand-name Other browsers tested: Firefox 3.x: OK IE 8: OK What steps will reproduce the problem? 1. Enter http://www.neowin.net/news/main/09/05/01/google-being-sued-over- the-android-brand-name 2. Look in your history ("Ctrl+H"), you should have a website called "Google being sued over the 'Android' brand name" 3. In that article you entered, Hover a few seconds on the the word "trademark"- which is colored light green and double-underlined, 4. Click on it (the word) and wait for the advertisement page to load 5. Look in your history again (refresh if still opened), the last website was replaced with that advertisement url for some reason ("Trademark - encyclopedia article about Trademark.") What is the expected result? i should have both urls in the history What happens instead? i only have the later
May 8 2009,
Confirmed, this is not a regression, it happens on all Chrome channels and Chromium trunk build. Please note that, even if the URL displayed in history will be replaced after redirect, it is still searchable.
Jun 6 2009,
this issue has nothing to do with those... unlike the issues you posted, here the "old" page is no longer listed in the History page at all it is replaced by the redirected one because of the non standard redirection method i guess the back button not working properly in this case is obvious but it originates from different reasons
Jun 6 2009,
Perhaps you should concentrate a bit more on reading than on writing. I cite from my description of Issue 13255 : "Note that after Step 1, the entry in the history is visible in chrome://history/. It only get's *replaced* by the next entry when you choose an item from the pulldown menu." This is EXACTLY it. Of course the back button function is screwed because the back button history reads from the full history. But nevertheless, fixing this issue here will solve all the other issues in one go. This is why I noted them here.
Jun 6 2009,
And there's another one, Issue 13392 .
Jun 6 2009,
Issue 2801 - try reproducing it while looking at (and refreshing) your history page... nothing is deleted & nothing is replaced Issue 1016 - try reproducing it while looking at (and refreshing) your history page... nothing is deleted & nothing is replaced BUT a new entry is added when pressing back, a useless one so it seems that doesn't take you back... Issue 9649 - nothing is replaced here really... or added there is one static entry in the history Issue 13090 has no real steps to test so that one is useless you are right about Issue 13255 though, that one might relate to my issue ( Issue 11355 )
Jun 6 2009,
At least in my Chrome v184.108.40.206 (Official Build 17570) it is like this: - I visit chromium.org. History says: 7:10 PM Chromium - Google Code (pages visited before) - I visit gmail.com. After that (F5 in history), history says: 7:11 PM Gmail 7:10 PM Chromium - Google Code (pages visited before) - I click Starred. After that (F5 in history), history says: 7:12 PM Inbox (1) - firstname.lastname@example.org - Gmail 7:10 PM Chromium - Google Code(pages visited before) - I click Chats. After that (F5 in history), history says: 7:13 PM Starred - email@example.com - Gmail 7:10 PM Chromium - Google Code (pages visited before) - I click Sent Mail. After that (F5 in history), history says: 7:14 PM Chats - firstname.lastname@example.org - Gmail 7:10 PM Chromium - Google Code (pages visited before) I won't repeat this for all the other issues, but there is definitely some history implication in this back button issue. At least in my installation.
Jun 6 2009,
I also did not mix up the history entries. It really says Inbox after clicking Starred, and it only says Starred after clicking Chats.
Jun 9 2009,
Jun 11 2009,
Jun 20 2009,
the back button now works, but the site is still replaced in the history page i imagine that the same logic used to tell the difference between a user initiated redirection to an automatic one in Issue 11896 should be used when replacing stuff in the history page
Jun 25 2009,
Jul 1 2009,
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=19708 ------------------------------------------------------------------------ r19708 | email@example.com | 2009-06-30 21:51:47 -0700 (Tue, 30 Jun 2009) | 16 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_contents_provider_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_url_provider_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history.h?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_marshaling.h?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_querying_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_model.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_model_unittest.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=19708&r2=19707 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/profiles/generate_profile.cc?r1=19708&r2=19707 Fix: Certain redirections remove sites from the history Currently, PageTransition::CHAIN_END flag is removed from a History database entry for a redirect source, even when the redirect is user initiated. This change prevents the flag removal for user-initiated redirects. TEST=Open http://www.google.com/ig and click on tabs multiple times. Without this change, only the last tab clicked appears in the History page (CTRL+H). With this change, all the tabs should appear. TESTED=gcl try, manually BUG= 11355 Review URL: http://codereview.chromium.org/147145 ------------------------------------------------------------------------
Jul 1 2009,
Looks like this bug can be closed now. Please reopen if there is more work to do.
Jul 3 2009,
Issue 13255 has been merged into this issue.
Dec 18 2009,
Oct 12 2012,
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Mar 10 2013,
Mar 13 2013,
Sign in to add a comment