Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 112301 Chrome: Crash Report - Stack Signature: ExtensionService::InitializePermissions(Extension const *)
Starred by 1 user Project Member Reported by kareng@google.com, Feb 1, 2012 Back to list
Status: Fixed
Owner: jstritar@chromium.org
Closed: Feb 2012
Cc: jam@chromium.org, aa@chromium.org
Components:
OS: ----
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Product: Chrome
Stack Signature: base::debug::BreakDebugger()-18EFB6A
New Signature Label: base::debug::BreakDebugger()
New Signature Hash: a80b176e_e861e229_fd5d9956_bb248a0c_d8c1039f

Report link: http://go/crash/reportdetail?reportid=c37f6415abc69f96

Meta information:
Product Name: Chrome
Product Version: 18.0.1025.1
Report ID: c37f6415abc69f96
Report Time: 2012/02/01 08:35:07, Wed
Uptime: 0 sec
Cumulative Uptime: 0 sec
OS Name: Windows NT
OS Version: 5.1.2600 Service Pack 3
CPU Architecture: x86
CPU Info: GenuineIntel family 6 model 15 stepping 11


Thread 0 *CRASHED* ( EXCEPTION_BREAKPOINT @ 0x02126431 )

0x02126431	 [chrome.dll	 - debugger_win.cc:107	base::debug::BreakDebugger()
0x01e81913	 [chrome.dll	 - extension_service.cc:2131	ExtensionService::InitializePermissions(Extension const *)
0x01e80cd2	 [chrome.dll	 - extension_service.cc:2047	ExtensionService::AddExtension(Extension const *)
0x0291856a	 [chrome.dll	 - installed_loader.cc:104	extensions::InstalledLoader::Load(ExtensionInfo const &,bool)
0x01e9ebea	 [chrome.dll	 - installed_loader.cc:153	extensions::InstalledLoader::LoadAllExtensions()
0x01e756ff	 [chrome.dll	 - extension_service.cc:585	ExtensionService::Init()
0x01e68a2b	 [chrome.dll	 - profile_impl.cc:474	ProfileImpl::InitExtensions(bool)
0x01e6863b	 [chrome.dll	 - profile_manager.cc:571	ProfileManager::DoFinalInitForServices(Profile *,bool)
0x01e6851e	 [chrome.dll	 - profile_manager.cc:559	ProfileManager::DoFinalInit(Profile *,bool)
0x01e6726f	 [chrome.dll	 - profile_manager.cc:413	ProfileManager::AddProfile(Profile *)
0x01cea45b	 [chrome.dll	 - profile_manager.cc:360	ProfileManager::GetProfile(FilePath const &)
0x01cea3b2	 [chrome.dll	 - profile_manager.cc:279	ProfileManager::GetLastUsedProfile(FilePath const &)
0x01cea20e	 [chrome.dll	 - chrome_browser_main.cc:408	`anonymous namespace'::CreateProfile(content::MainFunctionParams const &,FilePath const &,CommandLine const &)
0x01ce8d74	 [chrome.dll	 - chrome_browser_main.cc:1475	ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
0x01ce8ac9	 [chrome.dll	 - chrome_browser_main.cc:1320	ChromeBrowserMainParts::PreMainMessageLoopRun()
0x01cc5048	 [chrome.dll	 - browser_main_loop.cc:396	content::BrowserMainLoop::RunMainMessageLoopParts(bool *)
0x01cbe063	 [chrome.dll	 - browser_main.cc:100	BrowserMain(content::MainFunctionParams const &)
0x01c51fe3	 [chrome.dll	 - content_main.cc:264	`anonymous namespace'::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x01c454b3	 [chrome.dll	 - content_main.cc:457	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x01c45243	 [chrome.dll	 - chrome_main.cc:28	ChromeMain
0x00425238	 [chrome.exe	 - client_util.cc:342	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x0042471c	 [chrome.exe	 - chrome_exe_main_win.cc:36	wWinMain
0x004433fe	 [chrome.exe	 - crt0.c:263	__tmainCRTStartup
0x7c817076	 [kernel32.dll	 + 0x00017076]	BaseProcessStart

top crash on dev channel + branch

please take a look ASAP. 

 
Comment 1 by dharani@google.com, Feb 1, 2012
Summary: Chrome: Crash Report - Stack Signature: ExtensionService::InitializePermissions(Extension const *) (was: NULL)
Hm, must be related to http://codereview.chromium.org/9222013/
Comment 3 by dharani@google.com, Feb 1, 2012
Is this crash related? http://crash/reportdetail?reportid=06c5eb8fe3a439d3
Cc: -jstritar@chromium.org aa@chromium.org
Owner: jstritar@chromium.org
Status: Started
We're crashing here, http://goo.gl/hZymM, maybe for an unpacked extension. The strange thing is that GetGrantedPermissions only returns NULL if there are no preferences at all for the extension-- not if there are no granted permissions.

@dharani: Doesn't look related, but I can take a look at that one too. Can you create a bug and assign it to me?
Project Member Comment 5 by bugdroid1@chromium.org, Feb 1, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=120123

------------------------------------------------------------------------
r120123 | jstritar@chromium.org | Wed Feb 01 14:52:11 PST 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/unpacked/manifest_no_key.json?r1=120123&r2=120122&pathrev=120123
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/installed_loader.cc?r1=120123&r2=120122&pathrev=120123
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/unpacked?r1=120123&r2=120122&pathrev=120123
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/permissions_updater.cc?r1=120123&r2=120122&pathrev=120123
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=120123&r2=120122&pathrev=120123
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service_unittest.cc?r1=120123&r2=120122&pathrev=120123
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/unpacked/manifest_with_key.json?r1=120123&r2=120122&pathrev=120123

Fix crash in ExtensionService::InitializePermissions().

This crash occurs when an unpacked extension changes IDs by adding a key to its manifest. The extension preferences are stored under the old key. This started causing problems because now we record granted permissions for unpacked extensions.

BUG= 112301 
TEST=ExtensionServiceTest.UnpackedExtensionCanChangeID

Review URL: https://chromiumcodereview.appspot.com/9320021
------------------------------------------------------------------------
Labels: ReleaseBlock-Beta Merge-Requested
Comment 7 by kareng@google.com, Feb 1, 2012
Labels: -Merge-Requested Merge-Approved
Project Member Comment 8 by bugdroid1@chromium.org, Feb 1, 2012
Labels: -merge-approved merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=120127

------------------------------------------------------------------------
r120127 | jstritar@chromium.org | Wed Feb 01 15:23:47 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/common/extensions/extension.cc?r1=120127&r2=120126&pathrev=120127
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/extensions/extension_service_unittest.cc?r1=120127&r2=120126&pathrev=120127
 A http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/test/data/extensions/unpacked?r1=120127&r2=120126&pathrev=120127
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/extensions/permissions_updater.cc?r1=120127&r2=120126&pathrev=120127
 A http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/test/data/extensions/unpacked/manifest_with_key.json?r1=120127&r2=120126&pathrev=120127
 A http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/test/data/extensions/unpacked/manifest_no_key.json?r1=120127&r2=120126&pathrev=120127
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/extensions/installed_loader.cc?r1=120127&r2=120126&pathrev=120127

Merge 120123 - Fix crash in ExtensionService::InitializePermissions().

This crash occurs when an unpacked extension changes IDs by adding a key to its manifest. The extension preferences are stored under the old key. This started causing problems because now we record granted permissions for unpacked extensions.

BUG= 112301 
TEST=ExtensionServiceTest.UnpackedExtensionCanChangeID

Review URL: https://chromiumcodereview.appspot.com/9320021

TBR=jstritar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317042
------------------------------------------------------------------------
Status: Fixed
Project Member Comment 10 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 11 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-WebKit -Feature-Extensions -Mstone-18 Cr-Content Cr-Platform-Extensions M-18
Project Member Comment 12 by bugdroid1@chromium.org, Mar 13, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 13 by bugdroid1@chromium.org, Apr 6, 2013
Labels: -Cr-Content Cr-Blink
Sign in to add a comment