New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 112193 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2012
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

ChromeFrame: "Find Next" button does not work as intended for chrome frame rendered pages.

Reported by pshenoy@chromium.org, Jan 31 2012

Issue description

Chrome Frame Version       : 18.0.1025.0
Other browsers tested      : IE6/IE7/IE8

What steps will reproduce the problem?
1. Browse to any website rendered by chrome frame. (eg. www.yahoo.com)

2. Ctrl + F and search for any word in the webpage.

3. Click "Find Next" button in the "Find" dialog.

What is the expected result?
Should highlight the next occurrence of the searched word.

What happens instead?
It does not highlight the next occurrence instead stays on the first occurrence.

Note: It works fine with 17.0.963.46 build. This bug started happening from 18.0.995.0.


Please provide any additional information below. Attach a screenshot if
possible.

 
Cc: anan...@chromium.org

Comment 2 by kareng@google.com, Jan 31 2012

Owner: robertshield@chromium.org
Status: Assigned
Seeing in 19.0.1036.0 too.
Cc: kareng@google.com
Labels: ReleaseBlock-Stable
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=126904

------------------------------------------------------------------------
r126904 | robertshield@chromium.org | Thu Mar 15 06:50:00 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/find_dialog.cc?r1=126904&r2=126903&pathrev=126904
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_automation.cc?r1=126904&r2=126903&pathrev=126904
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/find_dialog.h?r1=126904&r2=126903&pathrev=126904

Correctly handle FindNext from the Find dialog.
Also handle unselecting the current selection when the Find dialog is dismissed.

BUG= 112193 
TEST=Open the find dialog in CF, search for the same string twice.


Review URL: http://codereview.chromium.org/9700053
------------------------------------------------------------------------
Labels: Merge-Requested
Status: Fixed


Comment 7 by kareng@google.com, Mar 15 2012

Labels: -Merge-Requested Merge-Approved

Comment 8 by kareng@google.com, Mar 15 2012

Labels: -Merge-Approved Merge-Requested
putting back to requested so i don't forget.

Comment 9 by kareng@google.com, Mar 21 2012

Labels: -Merge-Requested Merge-Approved

Comment 10 by kareng@google.com, Mar 21 2012

Labels: -Merge-Approved Merge-Requested

Comment 11 by kareng@google.com, Mar 23 2012

Labels: -Merge-Requested Merge-Merged
landed ths :)
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 23 2012

Labels: merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=128573

------------------------------------------------------------------------
r128573 | karen@chromium.org | Fri Mar 23 14:52:57 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/find_dialog.h?r1=128573&r2=128572&pathrev=128573
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/chrome_frame_automation.cc?r1=128573&r2=128572&pathrev=128573
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome_frame/find_dialog.cc?r1=128573&r2=128572&pathrev=128573

Merge 126904 - Correctly handle FindNext from the Find dialog.
Also handle unselecting the current selection when the Find dialog is dismissed.

BUG= 112193 
TEST=Open the find dialog in CF, search for the same string twice.


Review URL: http://codereview.chromium.org/9700053

TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9835066
------------------------------------------------------------------------
Status: Verified
Verified on 18.0.1025.140 beta.
Verified on OS: Linux Ubuntu 10.04, Win7, Mac 10.7.3, Chrome OS(Platform 1660.98.0 beta-channel x86-zgb)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Feature-ChromeFrame -Mstone-18 Type-Bug-Regression Cr-ChromeFrame M-18
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment