New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Uber Page Bug - clicking in empty space change settings (regression)

Reported by fabios4r...@gmail.com, Jan 31 2012

Issue description

Chrome Version       : 18.0.1025.0
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) : chrome://chrome/settings

if you click on the row of a setting on the white space (even far away), that setting is changed, even if not desired. This issue was fixed for old domui settings, reported as  issue 69792  - so please refer to that bug for more info!

What is the expected result?


What happens instead?


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.0 Safari/535.19


 

Comment 1 by meh...@chromium.org, Jan 31 2012

Labels: -Area-Undefined Area-UI OS-Mac Feature-Options
Status: Untriaged
Also confirmed on Mac OS with latest 18.0.1025.0 canary.
Labels: -OS-Windows -OS-Mac Mstone-18 OS-All
Owner: est...@chromium.org
Status: Assigned

Comment 3 by est...@chromium.org, Jan 31 2012

Labels: -Mstone-18
Labels: Mstone-18
If you don't think you're going to get it in M18, push the mstone to M19.

Comment 5 by est...@chromium.org, Jan 31 2012

Labels: -Mstone-18 Mstone-19
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 1 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=120033

------------------------------------------------------------------------
r120033 | estade@chromium.org | Tue Jan 31 20:57:04 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/shared/css/checkbox.css?r1=120033&r2=120032&pathrev=120033

uber settings - checkbox/radio clickability

change labels to -webkit-inline-box. This doesn't change the children but the box itself will behave like an inline element rather than block (won't expand horizontally). Also remove box flex on the span as it's not necessary. Also add some padding on the end of the labels so that there is extra clickable area when the text is short (this doesn't change anything if the span is long enough to wrap).

In native dialogs:
On Linux/GTK, the clickable area extends all the way to the right (our behavior before this patch).
On Mac, the clickable area is only the text and the checkbox
On Windows, the clickable area extends beyond the text but not all the way to the far right.

I'm splitting the difference by matching Windows native behavior, which seems both logical and the middle road.

BUG= 112091 
TEST=1. Checkbox labels should be clickable on either the text or the checkbox, but not more than 100px from the right edge of the checkbox. 2. Long labels still wrap with indent (see  bug 109334 )

Review URL: https://chromiumcodereview.appspot.com/9307015
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: -Feature-Options Feature-Settings
Labels: -Feature-Options Feature-Settings
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-19 -Feature-Settings Cr-UI-Settings Cr-UI M-19
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment