New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 7641
issue 21225
issue 103517



Sign in to add a comment
link

Issue 111593: Spellcheck should be able to run asynchronously

Reported by hbono@google.com, Jan 27 2012 Project Member

Issue description

(copied from <http://webkit.org/b/71991>.)

Once spellchecking has a unified text checking emulation by  Bug 65849 , 
we can use SpellChecker::requestCheckingFor() to run all spellchecking async. This will improve responsiveness of key typing.
 

Comment 1 by hbono@chromium.org, Jan 27 2012

Blocking: 21225

Comment 2 by hbono@chromium.org, Jan 27 2012

Blocking: 103517

Comment 3 by hbono@chromium.org, Jan 27 2012

Blocking: 7641

Comment 4 by hbono@chromium.org, Jan 27 2012

Cc: shinyak@chromium.org
Labels: -Area-Undefined Area-UI OS-All Feature-Spellcheck Mstone-19

Comment 5 by vivianz@chromium.org, Jan 27 2012

Status: Untriaged

Comment 6 by js...@chromium.org, Jan 27 2012

Cc: js...@chromium.org

Comment 7 by js...@chromium.org, Jan 27 2012

Labels: WebkitBug-71991
Two webkit bugs relevant to this :

https://bugs.webkit.org/show_bug.cgi?id=71991 
https://bugs.webkit.org/show_bug.cgi?id=65849  : a patch pending review. We may ping some people to get this reviewed?

Comment 8 by js...@chromium.org, Jan 27 2012

Cc: -shinyak@chromium.org
Owner: shinyak@chromium.org
Status: Assigned
shinyak already has a patch in the webkit bug. So, assigning this to him makes sense.

Comment 9 by laforge@google.com, Mar 27 2012

Labels: -Mstone-19 Mstone-20 MovedFrom-19

Comment 10 by bugdroid1@chromium.org, Apr 19 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=133029

------------------------------------------------------------------------
r133029 | shinyak@chromium.org | Thu Apr 19 11:58:23 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck.h?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/spellcheck_messages.h?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.cc?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.h?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck.cc?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_message_filter.cc?r1=133029&r2=133028&pathrev=133029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_unittest.cc?r1=133029&r2=133028&pathrev=133029

This patch implements asynchronous spellchecker on Windows and Linux.

Though Mac already has its own spellchecker, Linux and Windows don't have one. So we have implemented asynchronous spellchecker posting a task.

BUG= 6424 ,  111593 
TEST=SpellCheckTest.*


Review URL: http://codereview.chromium.org/9169082
------------------------------------------------------------------------

Comment 11 by dharani@google.com, May 8 2012

Labels: -Mstone-20 MovedFrom-20 Mstone-21
M20 has sailed. If this need to be part of M20, please put the Mstone-20 label back along with release block tag.

Comment 12 Deleted

Comment 13 by js...@chromium.org, Jun 1 2012

Hi,

I've noticed that you deleted the following comment of yours. Did you
delete it because you don't have this issue any more? Or, is there another
reason?  Of course, I'd be happy if you don't have an issue any more :-)

Jungshik

Comment 14 by karen@chromium.org, Jul 11 2012

Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone

Comment 15 by hbono@chromium.org, Aug 1 2012

Blocking: chromium:7641

Comment 16 by hbono@chromium.org, Aug 1 2012

Blocking: chromium:103517

Comment 17 by odean@chromium.org, Aug 14 2012

Cc: rlp@chromium.org odean@chromium.org
Should this bug still be open? (Cleaning up the Feature-Spellcheck bugbase while we transfer ownership)

Comment 18 by kareng@google.com, Aug 14 2012

Blocking: chromium:21225

Comment 19 by k...@google.com, Aug 31 2012

Labels: -Mstone-22 Mstone-23 MovedFrom-22
Moving all non-blocking 22 issues to 23.

Comment 20 by groby@chromium.org, Aug 31 2012

Cc: groby@chromium.org

Comment 21 by karen@chromium.org, Oct 10 2012

Blocking: -chromium:21225 -chromium:103517 -chromium:7641
Labels: -Mstone-23 MovedFrom-23 Mstone-24
Moving all non essential bugs to the next Milestone

Comment 22 by hbono@chromium.org, Oct 11 2012

Status: Fixed
Greetings,

I would like to close this issue since WebKit  Bug 71991  <http://webkit.org/71991> is fixed.

Regards,

Hironori Bono

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-Spellcheck -Mstone-24 Cr-UI M-24 Cr-UI-Browser-Spellcheck

Comment 24 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment