New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 111101 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
ooo sick wed dec 5
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 52468
issue 132910

Blocking:
issue 138772
issue 172741
issue 542415



Sign in to add a comment

Replace all PDF drawing with bitmaps and 2x bitmaps

Project Member Reported by thakis@chromium.org, Jan 23 2012

Issue description

Cole says that's more flexible and easier to handle. Do it.
 

Comment 1 by thakis@chromium.org, Jan 23 2012

Blockedon: 52468
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=120838

------------------------------------------------------------------------
r120838 | thakis@chromium.org | Tue Feb 07 14:13:55 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_resources.gyp?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/resource/resource_bundle_posix.cc?r1=120838&r2=120837&pathrev=120838
 D http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources_large.grd?r1=120838&r2=120837&pathrev=120838
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_large.grd?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/resource/resource_bundle_mac.mm?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/gritsettings/resource_ids?r1=120838&r2=120837&pathrev=120838
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_repack_theme_resources_2x.gypi?r1=120838&r2=120837&pathrev=120838
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_2x.grd?r1=120838&r2=120837&pathrev=120838
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources_2x.grd?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui_resources.gypi?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=120838&r2=120837&pathrev=120838
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_repack_theme_resources_large.gypi?r1=120838&r2=120837&pathrev=120838
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources_standard.grd?r1=120838&r2=120837&pathrev=120838

Rename _large.grd to _2x.grd

BUG= 111101 
TEST=none


Review URL: http://codereview.chromium.org/9307110
------------------------------------------------------------------------

Comment 3 by laforge@google.com, Mar 27 2012

Labels: -Mstone-19 Mstone-20 MovedFrom-19

Comment 4 by dharani@google.com, May 8 2012

Labels: -Mstone-20 MovedFrom-20 Mstone-21
M20 has sailed. If this need to be part of M20, please put the Mstone-20 label back along with release block tag.

Comment 6 by thakis@chromium.org, Jun 19 2012

Blockedon: 132910
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 26 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144313

------------------------------------------------------------------------
r144313 | thakis@chromium.org | Tue Jun 26 16:08:04 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_window_controller_cocoa.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/button_drag_utils.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_bridge.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_model.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/template_url_table_model.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm?r1=144313&r2=144312&pathrev=144313
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/default_favicon.png?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.h?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/favicon_source.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/DEPS?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/favicon_util.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.h?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources.grd?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_theme_service.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/task_manager_gtk.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_source_mac.mm?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.cc?r1=144313&r2=144312&pathrev=144313
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources_standard.grd?r1=144313&r2=144312&pathrev=144313

mac: Remove nav.pdf in favor of IDR_DEFAULT_FAVICON.

Copy default_100/default_large_favicon.png to default_200/default_favicon.png

BUG= 111101 
TEST=Favicons on bookmark bar, in history menu, etc still look good
in both lodpi and hidpi.
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10662041
------------------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144334

------------------------------------------------------------------------
r144334 | thakis@chromium.org | Tue Jun 26 17:24:55 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_script.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_star.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_extension_app.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/ash/app_list/search_builder.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_invalid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/default_large_favicon.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/default_favicon.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_valid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/default_favicon.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_cookies.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_cookies.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/star_lit.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_images.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_tts.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_tts.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_http.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_search.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_plugins.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_plugins.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_popups.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_match.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_star.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_script.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_extension_app.pdf?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_result_view.cc?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_valid.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_extension_app_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_warning.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/star_lit.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_images.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http_dark.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_tts.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_search.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_popups.png?r1=144334&r2=144333&pathrev=144334

HiDPI assets for omnibox icons.

Remove pdf files on Mac and use 2x pngs in the omnibox.

Side effect: The default favicon is now an empty page instead
of a globe.

BUG= 134372 , 111101 
TEST=icons in omnibox are hidpi and generally match the look
on non-mac platforms.
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10660021
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 3 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145338

------------------------------------------------------------------------
r145338 | thakis@chromium.org | Tue Jul 03 11:38:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/panels/panel_window_controller_cocoa.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/views/button_drag_utils.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/intents/web_intent_picker_model.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/search_engines/template_url_table_model.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/history_menu_bridge.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/task_manager/task_manager.cc?r1=145338&r2=145337&pathrev=145338
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_200_percent/default_favicon.png?r1=145338&r2=145337&pathrev=145338 (from /trunk/src/ui/resources/default_200_percent/default_favicon.png revision 144313)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/chrome_content_browser_client.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/DEPS?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/tab_contents/favicon_util.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/common/chrome_content_client.h?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/webui/favicon_source.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/public/common/content_client.h?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/gtk/gtk_theme_service.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_dll.gypi?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/public/common/content_client.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/ui_resources.grd?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/common/chrome_content_client.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/gtk/task_manager_gtk.cc?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/ui_resources_standard.grd?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/browser/web_contents/web_drag_source_mac.mm?r1=145338&r2=145337&pathrev=145338
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/content_browser.gypi?r1=145338&r2=145337&pathrev=145338

Merge 144313 - mac: Remove nav.pdf in favor of IDR_DEFAULT_FAVICON.

Copy default_100/default_large_favicon.png to default_200/default_favicon.png

BUG= 111101 
TEST=Favicons on bookmark bar, in history menu, etc still look good
in both lodpi and hidpi.
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10662041

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145343

------------------------------------------------------------------------
r145343 | thakis@chromium.org | Tue Jul 03 11:45:05 PDT 2012

Changed paths:
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_extension_app.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_popups.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_script.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_star.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_valid.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_warning.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http_dark.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources_standard.grd?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_search.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/star_lit.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_images.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_tts.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_dll.gypi?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_http.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_http.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_search.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_extension_app.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/ash/app_list/search_builder.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_popups.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/autocomplete/autocomplete_match.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources.grd?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_100_percent/default_large_favicon.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_invalid.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_script.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_star.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_star.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_100_percent/default_favicon.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_warning.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_valid.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_200_percent/default_favicon.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_cookies.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_cookies.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_extension_app_selected.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_http.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/star_lit.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_images.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http_selected.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_tts.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_tts.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_tts.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_plugins.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_search.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_search.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_plugins.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http.png?r1=145343&r2=145342&pathrev=145343

Merge 144334 - HiDPI assets for omnibox icons.

Remove pdf files on Mac and use 2x pngs in the omnibox.

Side effect: The default favicon is now an empty page instead
of a globe.

BUG= 134372 , 111101 
TEST=icons in omnibox are hidpi and generally match the look
on non-mac platforms.
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10660021

TBR=thakis@chromium.org
------------------------------------------------------------------------

Comment 11 by karen@chromium.org, Jul 11 2012

Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone
Blocking: chromium:138772

Comment 13 by k...@google.com, Aug 31 2012

Labels: -Mstone-22 MovedFrom-22 Mstone-23
Moving all non-blocking 22 issues to 23.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 13 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=156539

------------------------------------------------------------------------
r156539 | thakis@chromium.org | 2012-09-13T13:24:05.054190Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/browser_action_button.h?r1=156539&r2=156538&pathrev=156539
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/browser_action_button.mm?r1=156539&r2=156538&pathrev=156539

mac: Switch browser action backgrounds from vectors to bitmaps

Based on a patch from Andrew Bonventre <andybons@chromium.org>

BUG= 111101 
TEST=hover a browser action. highlight looks like the highlight on
the reload button.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10907212
------------------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 14 2012

Blockedon: -chromium:132910 -chromium:52468 chromium:132910 chromium:52468
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=156712

------------------------------------------------------------------------
r156712 | thakis@chromium.org | 2012-09-14T02:04:27.816589Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/InfoBar.xib?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/TabView.xib?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hover_close_button.h?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_shelf_controller.mm?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hover_close_button.mm?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/infobars/infobar_controller.h?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/FindBar.xib?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/infobars/infobar_controller.mm?r1=156712&r2=156711&pathrev=156712
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/DownloadShelf.xib?r1=156712&r2=156711&pathrev=156712

mac: Use the new close button asset instead of vector drawing.

This has the unfortunate side effect of making the close buttons red.
(Glen says he might reconsider the color if there's enough of an outcry.)

Move the infobar and findbar close buttons to the same close button asset used
on Windows (not red).

On the plus side, this reduces the number of files depending on the
molokocacao code.

xib changes:
DownloadShelf.xib, TabView.xib: Made the close button 18x18 instead of 16x16
FindBar.xib, InfoBar.xib: Made the close button a regular NSButton, gave its
                          cell the type ImageButtonCell.
FindBar.xib: Connected close button to the new closeButton_ outlet.

Parts based on a patch from Andrew Bonventre <andybons@chromium.org>

BUG= 52468 ,98453, 111101 

Review URL: https://codereview.chromium.org/10914252
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 14 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=156729

------------------------------------------------------------------------
r156729 | thakis@chromium.org | 2012-09-14T03:13:26.390984Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/otr_icon.pdf?r1=156729&r2=156728&pathrev=156729

Delete otr_icon.pdf. I forgot to do that in r156727.

BUG= 111101 
TBR=rsesek

Review URL: https://codereview.chromium.org/10905286
------------------------------------------------------------------------

Comment 18 by karen@chromium.org, Oct 10 2012

Labels: -Mstone-23 MovedFrom-23 Mstone-24
Moving all non essential bugs to the next Milestone
Labels: -Mstone-24
Since the bug has moved few times, removing the milestone label. Please target the right milestone.
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=174717

------------------------------------------------------------------------
r174717 | thakis@chromium.org | 2012-12-28T01:50:39.073763Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=174717&r2=174716&pathrev=174717
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/balloon_wrench.pdf?r1=174717&r2=174716&pathrev=174717
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll_bundle.gypi?r1=174717&r2=174716&pathrev=174717

mac: Replace notification wrench pdf with a png

BUG= 111101 
TEST=If on 10.8, change NotificationUIManager::Create() to always create
non-native notifications. Go to http://dangercove.github.com/html5-notifications/
and create a plain text notification, the wrench image should show up fine in
normal, hover, and pressed states.

Before: http://imgur.com/yBAz0,XM7fI#0
After: http://imgur.com/yBAz0,XM7fI#1


Review URL: https://chromiumcodereview.appspot.com/11691003
------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 18 2013

Blocking: chromium:172741
Summary: Replace all PDF drawing with bitmaps and 2x bitmaps (was: Replace all PDF / vector drawing with bitmaps and 2x bitmaps)
Let's make this bug just about pdfs. I filed  issue 172741  as a tracking bug for transitioning other ui from vectors to assets.
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 29 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179408

------------------------------------------------------------------------
r179408 | thakis@chromium.org | 2013-01-29T20:56:03.103014Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_image_util.cc?r1=179408&r2=179407&pathrev=179408
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources.grd?r1=179408&r2=179407&pathrev=179408
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/menu/menu_config_views.cc?r1=179408&r2=179407&pathrev=179408
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm?r1=179408&r2=179407&pathrev=179408
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/cros/menu_arrow.png?r1=179408&r2=179407&pathrev=179408
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/menu_hierarchy_arrow.pdf?r1=179408&r2=179407&pathrev=179408
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/cros/menu_arrow.png?r1=179408&r2=179407&pathrev=179408
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll_bundle.gypi?r1=179408&r2=179407&pathrev=179408

mac: Move bookmark hierarchy arrow from a pdf to a png.

Also use a slightly different asset on views.

BUG= 111101 
TEST=click a bookmark folder containing a bookmark folder. Hierarchy arrow still looks good.
TBR=sail

Review URL: https://codereview.chromium.org/12079033
------------------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Jan 30 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=179484

------------------------------------------------------------------------
r179484 | thakis@chromium.org | 2013-01-30T00:42:31.421920Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_source_mac.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_bridge.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm?r1=179484&r2=179483&pathrev=179484
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/nsimage_cache_unittest.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm?r1=179484&r2=179483&pathrev=179484
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/mac/nsimage_cache.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui.gyp?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=179484&r2=179483&pathrev=179484
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/mac/nsimage_cache.h?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm?r1=179484&r2=179483&pathrev=179484
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm?r1=179484&r2=179483&pathrev=179484

mac: Delete GetCachedImageWithName(), it's no longer used.

We used to load some images (mostly pdfs) from the app bundle instead
of from a pak file. We now load everything* from pak files, so this
is no longer necessary.

*: We still load 4 pdf files from the bundle via nib files, see  issue 111101 .

BUG= 138772 
TBR=avi

Review URL: https://codereview.chromium.org/12096047
------------------------------------------------------------------------
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI Cr-UI
So is this done?
No, there are 4 pdf assets left: The find next/prev icon, and the overflow arrows (up/down) for the bookmark menus: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_dll_bundle.gypi&q=%5C.pdf%20file:gyp%20-file:tools/gyp&sq=package:chromium&type=cs&l=59
Still 4 left.
Blocking: chromium:542415
Project Member

Comment 34 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a7cb89d023799cf759eb06532589d41ed384f2c

commit 3a7cb89d023799cf759eb06532589d41ed384f2c
Author: rsesek <rsesek@chromium.org>
Date: Mon May 02 19:46:06 2016

[Mac] Replace menu_overflow_{up,down}.pdf with PNGs.

This restores the PNG files that were deleted as unused in
85e1a36049a681b177265763b30a1a843fc3e820, and that were added in
2be293d247224360b64213691aa87da4b4830b7c.

BUG= 111101 
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/1936263002
Cr-Commit-Position: refs/heads/master@{#391030}

[modify] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/chrome/app/nibs/BookmarkBarFolderWindow.xib
[delete] https://crrev.com/1e213694248b28e9f15be63c006009e249063808/chrome/app/theme/menu_overflow_down.pdf
[delete] https://crrev.com/1e213694248b28e9f15be63c006009e249063808/chrome/app/theme/menu_overflow_up.pdf
[modify] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/chrome/chrome_dll_bundle.gypi
[add] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/ui/resources/default_100_percent/common/menu_overflow_down.png
[add] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/ui/resources/default_100_percent/common/menu_overflow_up.png
[add] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/ui/resources/default_200_percent/common/menu_overflow_down.png
[add] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/ui/resources/default_200_percent/common/menu_overflow_up.png
[modify] https://crrev.com/3a7cb89d023799cf759eb06532589d41ed384f2c/ui/resources/ui_resources.grd

Status: Fixed (was: Assigned)
rsesek++
Cc: rsesek@chromium.org

Sign in to add a comment