New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

scoped_refptr allows implicit conversion to raw pointer

Project Member Reported by dmichael@chromium.org, Jan 18 2012

Issue description

scoped_refptr provides:
operator T*() const { return ptr_; }
...which allows a scoped_refptr to be silently & implicitly converted to a raw pointer. This can make it too easy to mix/match scoped_refptrs with raw pointers inadvertently. Doing so can easily lead to memory leaks or use-after-free errors.

See discussion here:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/5a20cef75dd44f6b#

I have started a patch to remove it. Currently, it looks like the implicit conversion operator is used in 440 places (I'm getting 440 unique compile errors after removing it).
 
Showing comments 147 - 246 of 246 Older
Project Member

Comment 148 by bugdroid1@chromium.org, Aug 29 2014

Project Member

Comment 149 by bugdroid1@chromium.org, Aug 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57

commit 39030edb9763a85a699c52539a9fe4181d03bd57
Author: dcheng <dcheng@chromium.org>
Date: Fri Aug 29 10:13:57 2014

Net-related fixups for scoped_refptr conversion operator cleanup.

BUG= 110610 
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/511163002

Cr-Commit-Position: refs/heads/master@{#292600}

[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ssl/ssl_client_auth_observer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ssl/ssl_client_auth_observer.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ssl/ssl_client_auth_requestor_mock.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/chrome/browser/ui/views/ssl_client_certificate_selector.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/disk_cache/simple/simple_backend_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/disk_cache/simple/simple_index.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/disk_cache/simple/simple_index.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/http/transport_security_persister.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/http/transport_security_persister.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/socket/ssl_client_socket_openssl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/socket/ssl_client_socket_pool.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/39030edb9763a85a699c52539a9fe4181d03bd57/net/websockets/websocket_inflater_test.cc

Project Member

Comment 150 by bugdroid1@chromium.org, Aug 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd

commit 4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Aug 29 11:22:23 2014

Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (patchset #2 of https://codereview.chromium.org/511163002/)

Reason for revert:
It seems to be breaking GPU Mac Builder (Blink):
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19306/steps/compile/logs/stdio

Original issue's description:
> Net-related fixups for scoped_refptr conversion operator cleanup.
>
> BUG= 110610 
> TBR=pkasting@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/aa3dd9e5a2d3215f9c756ddcbb11268569cbe473

TBR=mmenke@chromium.org,rsleevi@chromium.org,pkasting@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 110610 

Review URL: https://codereview.chromium.org/517873003

Cr-Commit-Position: refs/heads/master@{#292606}

[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ssl/ssl_client_auth_observer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ssl/ssl_client_auth_observer.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ssl/ssl_client_auth_requestor_mock.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/chrome/browser/ui/views/ssl_client_certificate_selector.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/disk_cache/simple/simple_backend_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/disk_cache/simple/simple_index.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/disk_cache/simple/simple_index.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/http/transport_security_persister.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/http/transport_security_persister.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/socket/ssl_client_socket_openssl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/socket/ssl_client_socket_pool.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4f6bb368f9670e39657a0ffa40d1e7ddc8c914cd/net/websockets/websocket_inflater_test.cc

Project Member

Comment 153 by bugdroid1@chromium.org, Aug 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057

commit a07edc75077f184ff901495ce7af5764de67e057
Author: dcheng <dcheng@chromium.org>
Date: Fri Aug 29 17:44:50 2014

Media gallery fixups for scoped_refptr<T> operator T* removal.

BUG= 110610 

Review URL: https://codereview.chromium.org/518743002

Cr-Commit-Position: refs/heads/master@{#292664}

[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/fileapi/mtp_device_async_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/utility/media_galleries/image_metadata_extractor.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a07edc75077f184ff901495ce7af5764de67e057/chrome/utility/media_galleries/image_metadata_extractor.h

Project Member

Comment 154 by bugdroid1@chromium.org, Aug 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab

commit 6ef3c55508e568e191db4fbbd848b83fd445d7ab
Author: dcheng <dcheng@chromium.org>
Date: Sat Aug 30 05:34:19 2014

Manual fixups in gpu/ for scoped_refptr operator T* removal.

BUG= 110610 
TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/515943002

Cr-Commit-Position: refs/heads/master@{#292777}

[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/context_group.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/context_group.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/in_process_command_buffer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/query_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/service/transfer_buffer_manager_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/command_buffer/tests/gl_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6ef3c55508e568e191db4fbbd848b83fd445d7ab/gpu/gles2_conform_support/egl/display.cc

Project Member

Comment 156 by bugdroid1@chromium.org, Sep 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188

commit d3c60604e97ef9b681ad539ceffa601c0da62188
Author: dcheng <dcheng@chromium.org>
Date: Wed Sep 03 17:14:37 2014

content/ fixups for scoped_refptr operator T* removal.

BUG= 110610 
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/532833003

Cr-Commit-Position: refs/heads/master@{#293159}

[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/chrome/browser/platform_util_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/browser/utility_process_host_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/browser/utility_process_host_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/public/browser/utility_process_host.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/d3c60604e97ef9b681ad539ceffa601c0da62188/content/renderer/media/webmediaplayer_impl.cc

Project Member

Comment 158 by bugdroid1@chromium.org, Sep 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6

commit 707f860a000925a096b2631be0052affa1b1aec6
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 04 00:13:52 2014

Reland net-related fixups for scoped_refptr conversion operator cleanup.

BUG= 110610 
TBR=mmenke@chromium.org,pkasting@chromium.org,rsleevi@chromium.org

Review URL: https://codereview.chromium.org/536053003

Cr-Commit-Position: refs/heads/master@{#293231}

[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ssl/ssl_client_auth_observer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ssl/ssl_client_auth_observer.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ssl/ssl_client_auth_requestor_mock.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/chrome/browser/ui/views/ssl_client_certificate_selector.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/disk_cache/simple/simple_backend_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/disk_cache/simple/simple_index.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/disk_cache/simple/simple_index.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/http/transport_security_persister.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/http/transport_security_persister.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/socket/ssl_client_socket_openssl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/socket/ssl_client_socket_pool.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/707f860a000925a096b2631be0052affa1b1aec6/net/websockets/websocket_inflater_test.cc

Project Member

Comment 159 by bugdroid1@chromium.org, Sep 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f

commit 972bc39f4a28fa510bfb8c61f94e2e9b1897790f
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 04 04:22:38 2014

Fixups in components/ for scoped_refptr operator T* removal.

BUG= 110610 
TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/536623003

Cr-Commit-Position: refs/heads/master@{#293255}

[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/captive_portal/captive_portal_detector_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/feedback/feedback_uploader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/feedback/feedback_uploader.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/password_manager/core/browser/password_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/components/pdf/renderer/ppb_pdf_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/device/usb/usb_device_handle_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/972bc39f4a28fa510bfb8c61f94e2e9b1897790f/device/usb/usb_service_impl.cc

Project Member

Comment 160 by bugdroid1@chromium.org, Sep 5 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017

commit 37fac505ffd432f088abbc5056e7c72ca59ff017
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 05 05:28:13 2014

Random fixes for scoped_refptr operator T* removal.

BUG= 110610 
TBR=caitkp, michaeln, rockot, sievers, sky, willchan

Review URL: https://codereview.chromium.org/543893002

Cr-Commit-Position: refs/heads/master@{#293453}

[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/base/test/test_pending_task.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/extensions/extension_toolbar_model_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/extensions/location_bar_controller.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/extensions/location_bar_controller_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/net/quota_policy_channel_id_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/net/quota_policy_channel_id_store.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/chrome/browser/ui/app_list/search/history_data_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/components/variations/variations_seed_processor.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/device/usb/usb_device_handle_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/gpu/command_buffer/service/in_process_command_buffer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/37fac505ffd432f088abbc5056e7c72ca59ff017/storage/common/blob/scoped_file.cc

Project Member

Comment 162 by bugdroid1@chromium.org, Sep 5 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/664a17fefa8bc4b50763765281039afaf0db7b0d

commit 664a17fefa8bc4b50763765281039afaf0db7b0d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Sep 05 07:16:45 2014

Disable scoped_refptr operator T* on Linux builds.

The implicit conversion operator is being removed, because of the
surprises it can cause. For example, one might write:
  scoped_refptr<Foo> CreateFoo();
to ensure that callers hold the result in a scoped_refptr. But the
implicit conversion to T* means that a caller can accidentally hold
the result in a Foo* and the compiler won't catch it.

Since there are a large number of dependencies on this implicit
conversion, the cleanup is being conducted by a combination of
automated tooling and manual cleanup. It is also being staged on a
platform by platform basis. All known dependencies on the implicit
conversion on Linux (but not ChromeOS) have been removed, so this
patch disables the conversion operator on Linux builds to prevent
new dependencies on the implicit conversion.

Finally, to help facilitate this transition, temporary operator
overloads for comparison have been added. These will eventually be
removed.

BUG= 110610 
R=jyasskin@chromium.org, rsleevi@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/510323002

Cr-Commit-Position: refs/heads/master@{#293459}

[modify] https://chromium.googlesource.com/chromium/src.git/+/664a17fefa8bc4b50763765281039afaf0db7b0d/base/memory/ref_counted.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/664a17fefa8bc4b50763765281039afaf0db7b0d/base/memory/ref_counted_unittest.cc

Labels: no-sw
adding no-sw to remove this bug from a speculative query targeting Service Worker bug reports (doesn't seem specific to SW but let me know if there are things we ought to do).
Project Member

Comment 164 by bugdroid1@chromium.org, Sep 11 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b

commit 5adf8d2e938ff418fa0710ff1225261a59a3316b
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 11 00:53:37 2014

Remove implicit conversions from scoped_refptr to T* in chromeos/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/560903003

Cr-Commit-Position: refs/heads/master@{#294278}

[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/accelerometer/accelerometer_reader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/cert_loader_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/dbus/dbus_thread_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/dbus/debug_daemon_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/dbus/session_manager_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/client_cert_resolver.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/client_cert_resolver_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/network_cert_migrator.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/network_cert_migrator_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/network_connection_handler_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/5adf8d2e938ff418fa0710ff1225261a59a3316b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

Project Member

Comment 165 by bugdroid1@chromium.org, Sep 11 2014

Project Member

Comment 166 by bugdroid1@chromium.org, Sep 11 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727

commit fc25d1742bd3e7ab84ccbb71d8472ab1a03be727
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 11 03:08:44 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file*

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/564503002

Cr-Commit-Position: refs/heads/master@{#294309}

[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/fc25d1742bd3e7ab84ccbb71d8472ab1a03be727/chrome/browser/chromeos/fileapi/file_system_backend.cc

Project Member

Comment 167 by bugdroid1@chromium.org, Sep 12 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db

commit eff8449a3b1a008e78b0a157188e8e01983c71db
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 12 02:16:27 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/policy

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/549313004

Cr-Commit-Position: refs/heads/master@{#294526}

[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/policy_cert_verifier.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/eff8449a3b1a008e78b0a157188e8e01983c71db/chrome/browser/chromeos/policy/wildcard_login_checker.cc

Project Member

Comment 169 by bugdroid1@chromium.org, Sep 12 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388

commit 130d3f51c1f3e284f707719af4d364447d4d3388
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 12 19:20:16 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/login

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/563553005

Cr-Commit-Position: refs/heads/master@{#294629}

[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/fake_login_utils.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/screenshot_tester.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/130d3f51c1f3e284f707719af4d364447d4d3388/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

Project Member

Comment 170 by bugdroid1@chromium.org, Sep 12 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b66e11dac00cfeb4ff097ead712dae5acfe05986

commit b66e11dac00cfeb4ff097ead712dae5acfe05986
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 12 19:26:43 2014

Remove implicit conversion from scoped_refptr to T* in tools/gn

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/555163004

Cr-Commit-Position: refs/heads/master@{#294632}

[modify] https://chromium.googlesource.com/chromium/src.git/+/b66e11dac00cfeb4ff097ead712dae5acfe05986/tools/gn/scope.cc

Project Member

Comment 171 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc34a4c81c67aa7e980b360ddaebaeadd101ba95

commit cc34a4c81c67aa7e980b360ddaebaeadd101ba95
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:00:19 2014

Remove implicit conversions from scoped_refptr to T* in athena

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/571093003

Cr-Commit-Position: refs/heads/master@{#294888}

[modify] https://chromium.googlesource.com/chromium/src.git/+/cc34a4c81c67aa7e980b360ddaebaeadd101ba95/athena/system/orientation_controller.cc

Project Member

Comment 172 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfbf94b2614b6ec3c775fcfc3c56ccc7dc9f97c

commit 7cfbf94b2614b6ec3c775fcfc3c56ccc7dc9f97c
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:10:52 2014

Remove implicit conversions from scoped_refptr to T* in c/b/renderer_host/pepper

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/574463003

Cr-Commit-Position: refs/heads/master@{#294889}

[modify] https://chromium.googlesource.com/chromium/src.git/+/7cfbf94b2614b6ec3c775fcfc3c56ccc7dc9f97c/chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.cc

Project Member

Comment 173 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a861444c5870b42b12a6872009dd04811f404d2

commit 8a861444c5870b42b12a6872009dd04811f404d2
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:12:41 2014

Remove implicit conversions from scoped_refptr to T* in components/pairing

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/574513002

Cr-Commit-Position: refs/heads/master@{#294890}

[modify] https://chromium.googlesource.com/chromium/src.git/+/8a861444c5870b42b12a6872009dd04811f404d2/components/pairing/bluetooth_controller_pairing_controller.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8a861444c5870b42b12a6872009dd04811f404d2/components/pairing/bluetooth_host_pairing_controller.cc

Project Member

Comment 174 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36eac079abce6cd617a4ebf2ca63ff69aeaf7275

commit 36eac079abce6cd617a4ebf2ca63ff69aeaf7275
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:17:03 2014

Remove implicit conversions from scoped_refptr to T* in net

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/574513003

Cr-Commit-Position: refs/heads/master@{#294891}

[modify] https://chromium.googlesource.com/chromium/src.git/+/36eac079abce6cd617a4ebf2ca63ff69aeaf7275/net/cert/nss_cert_database_chromeos_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/36eac079abce6cd617a4ebf2ca63ff69aeaf7275/net/ssl/client_cert_store_chromeos_unittest.cc

Project Member

Comment 175 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d93099ad182ca1028ddcc99b1f5fe583ee0089

commit e0d93099ad182ca1028ddcc99b1f5fe583ee0089
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:21:22 2014

Remove implicit conversions from scoped_refptr to T* in ash

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/560223004

Cr-Commit-Position: refs/heads/master@{#294892}

[modify] https://chromium.googlesource.com/chromium/src.git/+/e0d93099ad182ca1028ddcc99b1f5fe583ee0089/ash/accelerometer/accelerometer_controller.cc

Project Member

Comment 176 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68b03e9002692d85a3b6c18130806e3b02dfb2f

commit e68b03e9002692d85a3b6c18130806e3b02dfb2f
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:24:58 2014

Remove implicit conversions from scoped_refptr to T* in content/common/gpu

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/552273004

Cr-Commit-Position: refs/heads/master@{#294893}

[modify] https://chromium.googlesource.com/chromium/src.git/+/e68b03e9002692d85a3b6c18130806e3b02dfb2f/content/common/gpu/media/rendering_helper.cc

Project Member

Comment 177 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62ae950bc92e8154fe1b2900e7b3ba8b864a472

commit d62ae950bc92e8154fe1b2900e7b3ba8b864a472
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 21:32:44 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/geolocation

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/577443002

Cr-Commit-Position: refs/heads/master@{#294896}

[modify] https://chromium.googlesource.com/chromium/src.git/+/d62ae950bc92e8154fe1b2900e7b3ba8b864a472/chrome/browser/chromeos/geolocation/simple_geolocation_provider.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/d62ae950bc92e8154fe1b2900e7b3ba8b864a472/chrome/browser/chromeos/geolocation/simple_geolocation_request.cc

Project Member

Comment 179 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76f8e9b111d04190775752cef0e5a18f6d0d0cf

commit f76f8e9b111d04190775752cef0e5a18f6d0d0cf
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 22:27:17 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/platform_keys

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/573863002

Cr-Commit-Position: refs/heads/master@{#294903}

[modify] https://chromium.googlesource.com/chromium/src.git/+/f76f8e9b111d04190775752cef0e5a18f6d0d0cf/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

Project Member

Comment 180 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d

commit 1ccca7731b337cfb20d9c58b00af8f4f6e16203d
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 22:32:12 2014

Remove implicit conversions from scoped_refptr to T* in extensions code.

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/564043004

Cr-Commit-Position: refs/heads/master@{#294904}

[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/chromeos/extensions/external_cache.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/1ccca7731b337cfb20d9c58b00af8f4f6e16203d/extensions/browser/api/usb/usb_api.cc

Project Member

Comment 181 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54672cdaacce980bf62aaa50b65ace634d2e5096

commit 54672cdaacce980bf62aaa50b65ace634d2e5096
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 22:50:26 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/attestation

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/567763003

Cr-Commit-Position: refs/heads/master@{#294909}

[modify] https://chromium.googlesource.com/chromium/src.git/+/54672cdaacce980bf62aaa50b65ace634d2e5096/chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc

Project Member

Comment 182 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4

commit 4c384d96adee499a0570238962c3ea34d56ed3a4
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 23:29:45 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/555253005

Cr-Commit-Position: refs/heads/master@{#294919}

[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/customization_wallpaper_downloader.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/preferences.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/timezone/timezone_provider.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/timezone/timezone_request.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/4c384d96adee499a0570238962c3ea34d56ed3a4/chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc

Project Member

Comment 183 by bugdroid1@chromium.org, Sep 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f900df2092632a68d22f06d61ac828ea6b6d63

commit 24f900df2092632a68d22f06d61ac828ea6b6d63
Author: dcheng <dcheng@chromium.org>
Date: Mon Sep 15 23:47:17 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/settings

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/568413004

Cr-Commit-Position: refs/heads/master@{#294930}

[modify] https://chromium.googlesource.com/chromium/src.git/+/24f900df2092632a68d22f06d61ac828ea6b6d63/chrome/browser/chromeos/settings/device_settings_service.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/24f900df2092632a68d22f06d61ac828ea6b6d63/chrome/browser/chromeos/settings/session_manager_operation.cc

Project Member

Comment 184 by bugdroid1@chromium.org, Sep 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abee4fef8c6b2078294f65f678d2f41e928ad311

commit abee4fef8c6b2078294f65f678d2f41e928ad311
Author: dcheng <dcheng@chromium.org>
Date: Tue Sep 16 00:22:44 2014

Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/556293004

Cr-Commit-Position: refs/heads/master@{#294940}

[modify] https://chromium.googlesource.com/chromium/src.git/+/abee4fef8c6b2078294f65f678d2f41e928ad311/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abee4fef8c6b2078294f65f678d2f41e928ad311/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Project Member

Comment 185 by bugdroid1@chromium.org, Sep 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0b69a5ebbe43f9278cf45682fd0d3dc9ebf743

commit 3f0b69a5ebbe43f9278cf45682fd0d3dc9ebf743
Author: dcheng <dcheng@chromium.org>
Date: Tue Sep 16 19:14:59 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/input_method

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/576503002

Cr-Commit-Position: refs/heads/master@{#295120}

[modify] https://chromium.googlesource.com/chromium/src.git/+/3f0b69a5ebbe43f9278cf45682fd0d3dc9ebf743/chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Project Member

Comment 186 by bugdroid1@chromium.org, Sep 16 2014

Project Member

Comment 187 by bugdroid1@chromium.org, Sep 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36524115b4cd0841c2d07f5b184d67beac6fb04a

commit 36524115b4cd0841c2d07f5b184d67beac6fb04a
Author: dcheng <dcheng@chromium.org>
Date: Tue Sep 16 23:38:19 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/ownership

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/569173006

Cr-Commit-Position: refs/heads/master@{#295176}

[modify] https://chromium.googlesource.com/chromium/src.git/+/36524115b4cd0841c2d07f5b184d67beac6fb04a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Project Member

Comment 188 by bugdroid1@chromium.org, Sep 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c0930e5a6d6ca2921f6121f20d5de7604af3e5a

commit 0c0930e5a6d6ca2921f6121f20d5de7604af3e5a
Author: dcheng <dcheng@chromium.org>
Date: Wed Sep 17 03:50:51 2014

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file_system_provider

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG= 110610 

Review URL: https://codereview.chromium.org/579663002

Cr-Commit-Position: refs/heads/master@{#295224}

[modify] https://chromium.googlesource.com/chromium/src.git/+/0c0930e5a6d6ca2921f6121f20d5de7604af3e5a/chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc

Project Member

Comment 189 by bugdroid1@chromium.org, Sep 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e6ba5a2c981b0b0c82d40e45e712c02480f2d6c

commit 1e6ba5a2c981b0b0c82d40e45e712c02480f2d6c
Author: dcheng <dcheng@chromium.org>
Date: Wed Sep 17 05:35:23 2014

Disable implicit conversions of scoped_refptr to T* on CrOS.

The implicit conversion has already been disabled for Linux builds for
some time now. https://codereview.chromium.org/510323002 explains the
rationale for proceeding incrementally.

BUG= 110610 

Review URL: https://codereview.chromium.org/572713003

Cr-Commit-Position: refs/heads/master@{#295234}

[modify] https://chromium.googlesource.com/chromium/src.git/+/1e6ba5a2c981b0b0c82d40e45e712c02480f2d6c/base/memory/ref_counted.h

Project Member

Comment 190 by bugdroid1@chromium.org, Sep 17 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38dbbbfd47e202bf55db0a8149ef0e1c7284e995

commit 38dbbbfd47e202bf55db0a8149ef0e1c7284e995
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Sep 17 07:34:54 2014

Remove implicit conversion from scoped_refptr to T* in UserSessionManager

This wasn't caught by the trybots or CQ since this is only compiled in
official builds.

BUG= 110610 
TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/574793004

Cr-Commit-Position: refs/heads/master@{#295237}

[modify] https://chromium.googlesource.com/chromium/src.git/+/38dbbbfd47e202bf55db0a8149ef0e1c7284e995/chrome/browser/chromeos/login/session/user_session_manager.cc

Project Member

Comment 191 by bugdroid1@chromium.org, Sep 19 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7dd48b1c3af2de5d8e4e05b5e9e40008617c68f

commit d7dd48b1c3af2de5d8e4e05b5e9e40008617c68f
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 19 17:56:24 2014

Remove implicit conversions from scoped_refptr to T* in device/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG= 110610 

Review URL: https://codereview.chromium.org/584083002

Cr-Commit-Position: refs/heads/master@{#295732}

[modify] https://chromium.googlesource.com/chromium/src.git/+/d7dd48b1c3af2de5d8e4e05b5e9e40008617c68f/device/bluetooth/bluetooth_socket_mac.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/d7dd48b1c3af2de5d8e4e05b5e9e40008617c68f/device/hid/hid_service_mac.cc

Project Member

Comment 192 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61b83a1c18ec9e4e8ea5fe4795131c6eb6ac2521

commit 61b83a1c18ec9e4e8ea5fe4795131c6eb6ac2521
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 01:01:28 2014

Remove implicit conversions from scoped_refptr to T* in media/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG= 110610 

Review URL: https://codereview.chromium.org/584103002

Cr-Commit-Position: refs/heads/master@{#295837}

[modify] https://chromium.googlesource.com/chromium/src.git/+/61b83a1c18ec9e4e8ea5fe4795131c6eb6ac2521/media/video/capture/mac/video_capture_device_factory_mac.mm

Project Member

Comment 194 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160

commit 037fdb5001271435af339b1d165e5512004eb160
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 03:22:09 2014

Remove implicit conversions from scoped_refptr to T* in chrome/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG= 110610 

Review URL: https://codereview.chromium.org/591493002

Cr-Commit-Position: refs/heads/master@{#295854}

[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/app_controller_mac.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/browser_process_platform_part_mac.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/media_galleries/fileapi/picasa_data_provider.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/037fdb5001271435af339b1d165e5512004eb160/chrome/utility/image_writer/disk_unmounter_mac.cc

Project Member

Comment 195 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c041fef8226db56fcec101567c9eef0f9ce49ef5

commit c041fef8226db56fcec101567c9eef0f9ce49ef5
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 03:31:22 2014

Remove implicit conversions from scoped_refptr to T* in base/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG= 110610 

Review URL: https://codereview.chromium.org/584883003

Cr-Commit-Position: refs/heads/master@{#295855}

[modify] https://chromium.googlesource.com/chromium/src.git/+/c041fef8226db56fcec101567c9eef0f9ce49ef5/base/files/file_path_watcher_mac.cc

Project Member

Comment 196 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11270b34fa8d3a2258f2b8687f575552ca4f2cb

commit e11270b34fa8d3a2258f2b8687f575552ca4f2cb
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 13:23:06 2014

Remove implicit conversions from scoped_refptr to T* in PasswordStoreMac test.

- Add a .get() to a boolean test until boolean tests on scoped_refptr
  can be re-enabled.
- Change the test fixture store() accessor to just return a raw pointer,
  since no one depends on it returning a scoped_refptr anyway.

BUG= 110610 
TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/584373002

Cr-Commit-Position: refs/heads/master@{#295873}

[modify] https://chromium.googlesource.com/chromium/src.git/+/e11270b34fa8d3a2258f2b8687f575552ca4f2cb/chrome/browser/password_manager/password_store_mac_unittest.cc

Project Member

Comment 197 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e

commit 4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 14:53:11 2014

Remove implicit conversions from scoped_refptr to T* in FileWatcher.

Since set_message_loop() takes ownership of the MessageLoop
parameter anyway, just pass it a const scoped_refptr<T>&, rather
than converting from scoped_refptr to T* back to scoped_refptr.

BUG= 110610 
TBR=rvargas@chromioum.org

Review URL: https://codereview.chromium.org/588003002

Cr-Commit-Position: refs/heads/master@{#295875}

[modify] https://chromium.googlesource.com/chromium/src.git/+/4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e/base/files/file_path_watcher.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e/base/files/file_path_watcher_linux.cc

Project Member

Comment 198 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed3e65c71b7566004fc75da2799f1f9e7e4b299c

commit ed3e65c71b7566004fc75da2799f1f9e7e4b299c
Author: dcheng <dcheng@chromium.org>
Date: Sat Sep 20 20:53:32 2014

Disable implicit conversions of scoped_refptr to T* on Mac.

The implicit conversion has already been disabled for Linux and ChromeOS
builds. https://codereview.chromium.org/510323002 explains the rationale
for proceeding incrementally.

BUG= 110610 
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/589853002

Cr-Commit-Position: refs/heads/master@{#295889}

[modify] https://chromium.googlesource.com/chromium/src.git/+/ed3e65c71b7566004fc75da2799f1f9e7e4b299c/base/memory/ref_counted.h

Project Member

Comment 199 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbbea1851548ac4bb6195447c6e3e06b796a5f40

commit bbbea1851548ac4bb6195447c6e3e06b796a5f40
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 03:13:20 2014

Remove implicit conversions from scoped_refptr to T* in ui/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/624283003

Cr-Commit-Position: refs/heads/master@{#298344}

[modify] https://chromium.googlesource.com/chromium/src.git/+/bbbea1851548ac4bb6195447c6e3e06b796a5f40/ui/gl/gl_image_surface_texture.cc

Project Member

Comment 200 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/024576337382bdc13217025de4c65efb839335fb

commit 024576337382bdc13217025de4c65efb839335fb
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 03:13:40 2014

Remove implicit conversions from scoped_refptr to T* in gpu/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/632863002

Cr-Commit-Position: refs/heads/master@{#298345}

[modify] https://chromium.googlesource.com/chromium/src.git/+/024576337382bdc13217025de4c65efb839335fb/gpu/command_buffer/service/stream_texture_manager_in_process_android.cc

Project Member

Comment 201 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fdc1ea5e9111d3594d4c25c1266764d5925d7c4

commit 9fdc1ea5e9111d3594d4c25c1266764d5925d7c4
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 03:16:12 2014

Remove implicit conversions from scoped_refptr to T* in chrome/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/634683002

Cr-Commit-Position: refs/heads/master@{#298346}

[modify] https://chromium.googlesource.com/chromium/src.git/+/9fdc1ea5e9111d3594d4c25c1266764d5925d7c4/chrome/browser/android/intercept_download_resource_throttle.cc

Project Member

Comment 202 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968

commit 6124468a6cc7365a7b6d9b8aab690ca0df225968
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 03:54:29 2014

Remove implicit conversions from scoped_refptr to T* in content/*/media

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/635623002

Cr-Commit-Position: refs/heads/master@{#298356}

[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/browser/media/android/browser_media_player_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/renderer/media/android/media_source_delegate.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/renderer/media/android/stream_texture_factory_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/renderer/media/android/stream_texture_factory_synchronous_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6124468a6cc7365a7b6d9b8aab690ca0df225968/content/renderer/media/android/webmediaplayer_android.cc

Project Member

Comment 203 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747

commit 165763c20c375201e93c5663f6b1fc0834503747
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 04:14:54 2014

Remove implicit conversions from scoped_refptr to T* in content/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/628333003

Cr-Commit-Position: refs/heads/master@{#298364}

[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/android/in_process/synchronous_compositor_factory_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/android/in_process/synchronous_compositor_output_surface.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/android/overscroll_glow.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/android/surface_texture_peer_browser_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/power_save_blocker_android.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/renderer_host/image_transport_factory_android.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/browser/web_contents/web_contents_android.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/165763c20c375201e93c5663f6b1fc0834503747/content/common/gpu/stream_texture_android.cc

Project Member

Comment 204 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eb8b4f58a683620917fb3d71a91504ebecd7922

commit 0eb8b4f58a683620917fb3d71a91504ebecd7922
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 10:07:51 2014

Remove implicit conversions from scoped_refptr to T* in net/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/632873002

Cr-Commit-Position: refs/heads/master@{#298434}

[modify] https://chromium.googlesource.com/chromium/src.git/+/0eb8b4f58a683620917fb3d71a91504ebecd7922/net/cert/cert_verify_proc_android.cc

Project Member

Comment 206 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442517ec3f796a41041ce11ff00210a19ffbb919

commit 442517ec3f796a41041ce11ff00210a19ffbb919
Author: dcheng <dcheng@chromium.org>
Date: Tue Oct 07 20:55:53 2014

Remove implicit conversions from scoped_refptr to T* in remoting/

This patch was generated by running the rewrite_scoped_refptr clang tool
on an Android build.

BUG= 110610 

Review URL: https://codereview.chromium.org/635013002

Cr-Commit-Position: refs/heads/master@{#298567}

[modify] https://chromium.googlesource.com/chromium/src.git/+/442517ec3f796a41041ce11ff00210a19ffbb919/remoting/client/jni/chromoting_jni_runtime.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/442517ec3f796a41041ce11ff00210a19ffbb919/remoting/client/jni/chromoting_jni_runtime.h

Project Member

Comment 207 by bugdroid1@chromium.org, Oct 8 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46256f8d8aa293e87c9d524fbf16b8846a1d203d

commit 46256f8d8aa293e87c9d524fbf16b8846a1d203d
Author: dcheng <dcheng@chromium.org>
Date: Wed Oct 08 16:46:56 2014

Remove implicit conversions from scoped_refptr to T* in android_webview/

Manual fixups for cases the automated tooling elected to skip.

BUG= 110610 

Review URL: https://codereview.chromium.org/631313003

Cr-Commit-Position: refs/heads/master@{#298731}

[modify] https://chromium.googlesource.com/chromium/src.git/+/46256f8d8aa293e87c9d524fbf16b8846a1d203d/android_webview/native/aw_contents_client_bridge.cc

Project Member

Comment 210 by bugdroid1@chromium.org, Oct 9 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de79af545b0c5c023a32e24761f776e8fb04ab7e

commit de79af545b0c5c023a32e24761f776e8fb04ab7e
Author: dcheng <dcheng@chromium.org>
Date: Thu Oct 09 07:13:43 2014

Disable implicit conversions from scoped_refptr to T* on Android.

BUG= 110610 

Review URL: https://codereview.chromium.org/636143003

Cr-Commit-Position: refs/heads/master@{#298820}

[modify] https://chromium.googlesource.com/chromium/src.git/+/de79af545b0c5c023a32e24761f776e8fb04ab7e/base/memory/ref_counted.h

Project Member

Comment 211 by bugdroid1@chromium.org, Oct 11 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad794d3c472690a8f9ac1772b56829185c177d00

commit ad794d3c472690a8f9ac1772b56829185c177d00
Author: dcheng <dcheng@chromium.org>
Date: Sat Oct 11 06:55:20 2014

Disable implicit conversions from scoped_refptr to T* on iOS.

BUG= 110610 

Review URL: https://codereview.chromium.org/643193002

Cr-Commit-Position: refs/heads/master@{#299238}

[modify] https://chromium.googlesource.com/chromium/src.git/+/ad794d3c472690a8f9ac1772b56829185c177d00/base/memory/ref_counted.h

Project Member

Comment 213 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96

commit 8dad9e1727426d5474125223b7dc1da1916c3c96
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 00:04:36 2014

Remove implicit conversions from scoped_refptr to T* in chrome/browser

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/718213004

Cr-Commit-Position: refs/heads/master@{#303929}

[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/enumerate_modules_model_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/extensions/extension_toolbar_model_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/jumplist_updater_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/jumplist_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/local_discovery/service_discovery_shared_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/media_galleries/win/mtp_device_operations_util.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/printing/print_view_manager_base.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/8dad9e1727426d5474125223b7dc1da1916c3c96/chrome/browser/profile_resetter/profile_resetter.cc

Project Member

Comment 216 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6ae495cf2dd5117d0d209c25169710c491f992

commit 8c6ae495cf2dd5117d0d209c25169710c491f992
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 00:48:31 2014

Remove implicit conversions from scoped_refptr to T* in device/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/720973002

Cr-Commit-Position: refs/heads/master@{#303940}

[modify] https://chromium.googlesource.com/chromium/src.git/+/8c6ae495cf2dd5117d0d209c25169710c491f992/device/bluetooth/bluetooth_adapter_win.cc

Project Member

Comment 221 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d219ec9112c692fecde412963f0b45b7b7fd6b

commit 58d219ec9112c692fecde412963f0b45b7b7fd6b
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 18:05:32 2014

Remove implicit conversions from scoped_refptr to T* in components/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/717263004

Cr-Commit-Position: refs/heads/master@{#304046}

[modify] https://chromium.googlesource.com/chromium/src.git/+/58d219ec9112c692fecde412963f0b45b7b7fd6b/components/storage_monitor/portable_device_watcher_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/58d219ec9112c692fecde412963f0b45b7b7fd6b/components/wifi/wifi_service_win.cc

Project Member

Comment 222 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be20825ffd218323b94626bb069a1980accf5289

commit be20825ffd218323b94626bb069a1980accf5289
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 23:06:42 2014

Remove implicit conversions from scoped_refptr to T* in printing/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/723743003

Cr-Commit-Position: refs/heads/master@{#304105}

[modify] https://chromium.googlesource.com/chromium/src.git/+/be20825ffd218323b94626bb069a1980accf5289/printing/backend/print_backend_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/be20825ffd218323b94626bb069a1980accf5289/printing/backend/win_helper.cc

Project Member

Comment 223 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6041e1341aad67fd5675ab9edacc2df4916420

commit 4a6041e1341aad67fd5675ab9edacc2df4916420
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 23:07:05 2014

Remove implicit conversions from scoped_refptr to T* in base/win/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/719363002

Cr-Commit-Position: refs/heads/master@{#304106}

[modify] https://chromium.googlesource.com/chromium/src.git/+/4a6041e1341aad67fd5675ab9edacc2df4916420/base/win/scoped_comptr_unittest.cc

Project Member

Comment 224 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d

commit 6a37ed84687435709790acb73f20bbf3f862ae3d
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 23:29:37 2014

Remove implicit conversions from scoped_refptr to T* in media/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/720983002

Cr-Commit-Position: refs/heads/master@{#304111}

[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/audio/win/audio_device_listener_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/audio/win/audio_low_latency_input_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/audio/win/audio_low_latency_output_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/audio/win/core_audio_util_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/audio/win/core_audio_util_win_unittest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/video/capture/win/filter_base_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/video/capture/win/pin_base_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/video/capture/win/video_capture_device_factory_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/video/capture/win/video_capture_device_mf_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/6a37ed84687435709790acb73f20bbf3f862ae3d/media/video/capture/win/video_capture_device_win.cc

Project Member

Comment 225 by bugdroid1@chromium.org, Nov 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da4d40742403e9a9cad302473f4dce1745a149f

commit 4da4d40742403e9a9cad302473f4dce1745a149f
Author: dcheng <dcheng@chromium.org>
Date: Thu Nov 13 23:30:51 2014

Remove implicit conversions from scoped_refptr to T* in ash/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/720753003

Cr-Commit-Position: refs/heads/master@{#304113}

[modify] https://chromium.googlesource.com/chromium/src.git/+/4da4d40742403e9a9cad302473f4dce1745a149f/ash/system/win/audio/tray_audio_delegate_win.cc

Project Member

Comment 226 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6807750b05094442ceb5b101bd50ac723e830a6e

commit 6807750b05094442ceb5b101bd50ac723e830a6e
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 18:14:01 2014

Remove implicit conversions from scoped_refptr to T* in device/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/748093002

Cr-Commit-Position: refs/heads/master@{#305241}

[modify] http://crrev.com/6807750b05094442ceb5b101bd50ac723e830a6e/device/bluetooth/bluetooth_task_manager_win.cc

Project Member

Comment 227 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2853efe72b4d096851190f1375b889cf4cfadb4

commit c2853efe72b4d096851190f1375b889cf4cfadb4
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 18:25:25 2014

Remove implicit conversions from scoped_refptr to T* in remoting/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/751513003

Cr-Commit-Position: refs/heads/master@{#305242}

[modify] http://crrev.com/c2853efe72b4d096851190f1375b889cf4cfadb4/remoting/host/win/rdp_client.cc
[modify] http://crrev.com/c2853efe72b4d096851190f1375b889cf4cfadb4/remoting/host/win/rdp_client_window.cc

Project Member

Comment 228 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abb3854c75b17a68b58bc7267faae3f743c449b

commit 9abb3854c75b17a68b58bc7267faae3f743c449b
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 18:29:08 2014

Remove implicit conversions from scoped_refptr to T* in components/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/746213002

Cr-Commit-Position: refs/heads/master@{#305244}

[modify] http://crrev.com/9abb3854c75b17a68b58bc7267faae3f743c449b/components/component_updater/background_downloader_win.cc
[modify] http://crrev.com/9abb3854c75b17a68b58bc7267faae3f743c449b/components/storage_monitor/volume_mount_watcher_win.cc

Project Member

Comment 229 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8ae6515a375c2c325fafe51e94f982cb62031f

commit ff8ae6515a375c2c325fafe51e94f982cb62031f
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 19:14:20 2014

Remove implicit conversions from scoped_refptr to T* in cloud_print/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/745323002

Cr-Commit-Position: refs/heads/master@{#305255}

[modify] http://crrev.com/ff8ae6515a375c2c325fafe51e94f982cb62031f/cloud_print/service/win/cloud_print_service_config.cc

Project Member

Comment 230 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3c56d51dac268caa4186b27eb3f738ce85b8d20

commit f3c56d51dac268caa4186b27eb3f738ce85b8d20
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 21:01:49 2014

Remove implicit conversions from scoped_refptr to T* in base/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/750063002

Cr-Commit-Position: refs/heads/master@{#305277}

[modify] http://crrev.com/f3c56d51dac268caa4186b27eb3f738ce85b8d20/base/test/test_shortcut_win.cc
[modify] http://crrev.com/f3c56d51dac268caa4186b27eb3f738ce85b8d20/base/win/shortcut.cc

Project Member

Comment 232 by bugdroid1@chromium.org, Nov 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81762e001c5c58b778a883fdace89975db9ee084

commit 81762e001c5c58b778a883fdace89975db9ee084
Author: dcheng <dcheng@chromium.org>
Date: Fri Nov 21 21:22:28 2014

Remove implicit conversions from scoped_refptr to T* in chrome/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG= 110610 

Review URL: https://codereview.chromium.org/745333002

Cr-Commit-Position: refs/heads/master@{#305286}

[modify] http://crrev.com/81762e001c5c58b778a883fdace89975db9ee084/chrome/browser/metro_utils/metro_chrome_win.cc
[modify] http://crrev.com/81762e001c5c58b778a883fdace89975db9ee084/chrome/browser/shell_integration_win.cc
[modify] http://crrev.com/81762e001c5c58b778a883fdace89975db9ee084/chrome/browser/ui/pdf/adobe_reader_info_win.cc

Project Member

Comment 233 by bugdroid1@chromium.org, Nov 21 2014

Project Member

Comment 234 by bugdroid1@chromium.org, Nov 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf0e997843feaed395372eb8fcef402c1bebf18

commit edf0e997843feaed395372eb8fcef402c1bebf18
Author: dcheng <dcheng@chromium.org>
Date: Sat Nov 22 18:14:02 2014

Fix implicit conversion of scoped_refptr<T> to T* in PasswordStoreWin.

Since PasswordStoreWin::DBHandler ends up retaining a reference,
indicate this by passing a scoped_refptr<PasswordWebDataService>.

BUG= 110610 

Review URL: https://codereview.chromium.org/751813002

Cr-Commit-Position: refs/heads/master@{#305367}

[modify] http://crrev.com/edf0e997843feaed395372eb8fcef402c1bebf18/chrome/browser/password_manager/password_store_win.cc
[modify] http://crrev.com/edf0e997843feaed395372eb8fcef402c1bebf18/chrome/browser/password_manager/password_store_win.h

Project Member

Comment 235 by bugdroid1@chromium.org, Nov 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381dc3fd5b9f081203e55c2e01ab32a1d70c0711

commit 381dc3fd5b9f081203e55c2e01ab32a1d70c0711
Author: dcheng <dcheng@chromium.org>
Date: Sat Nov 22 18:23:53 2014

Remove implicit conversion from scoped_refptr<T> to T* in media

BUG= 110610 

Review URL: https://codereview.chromium.org/754473004

Cr-Commit-Position: refs/heads/master@{#305368}

[modify] http://crrev.com/381dc3fd5b9f081203e55c2e01ab32a1d70c0711/media/video/capture/win/sink_filter_win.cc

Project Member

Comment 236 by bugdroid1@chromium.org, Nov 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df07d905b283b05c3461d55bff06142ec6b8a2c4

commit df07d905b283b05c3461d55bff06142ec6b8a2c4
Author: dcheng <dcheng@chromium.org>
Date: Mon Nov 24 19:13:43 2014

Fix implicit conversion of scoped_refptr<T> to T* in components/nacl

Since it's generally an anti-pattern to keep a pointer to a
MessageLoopProxy without ref'ing it, the message_loop_ member is now
a scoped_refptr<T>.

BUG= 110610 

Review URL: https://codereview.chromium.org/750263002

Cr-Commit-Position: refs/heads/master@{#305466}

[modify] http://crrev.com/df07d905b283b05c3461d55bff06142ec6b8a2c4/components/nacl/common/nacl_debug_exception_handler_win.cc
[modify] http://crrev.com/df07d905b283b05c3461d55bff06142ec6b8a2c4/components/nacl/common/nacl_debug_exception_handler_win.h

Project Member

Comment 237 by bugdroid1@chromium.org, Nov 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62e00050f20843892035e460db6fe99e0f381b2

commit f62e00050f20843892035e460db6fe99e0f381b2
Author: dcheng <dcheng@chromium.org>
Date: Mon Nov 24 20:13:21 2014

Fix implicit scoped_refptr<T> to T* conversion in TestMetroViewerProcessHost

Since MetroViewerProcessHost ends up ref'ing the TaskRunner, pass it as a
scoped_refptr<T> to provide a hint to readers and eliminate the implicit
conversion.

BUG= 110610 

Review URL: https://codereview.chromium.org/750273002

Cr-Commit-Position: refs/heads/master@{#305484}

[modify] http://crrev.com/f62e00050f20843892035e460db6fe99e0f381b2/ash/test/test_metro_viewer_process_host.cc
[modify] http://crrev.com/f62e00050f20843892035e460db6fe99e0f381b2/ash/test/test_metro_viewer_process_host.h

Project Member

Comment 238 by bugdroid1@chromium.org, Nov 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90590193a9c5b5bc674f1c7680761306ed42c1f1

commit 90590193a9c5b5bc674f1c7680761306ed42c1f1
Author: dcheng <dcheng@chromium.org>
Date: Mon Nov 24 22:58:56 2014

Remove remaining implicit scoped_ptr<T> to T* conversions in win8

GetArgumentsFromShortcut() introduced a new implicit conversion
since the last time the clang tool was run.
The other fix in MetroViewerProcessHost simply changes the
TaskRunner pointer to be passed as a scoped_refptr<T>, since it
takes a ref to the TaskRunner.

BUG= 110610 

Review URL: https://codereview.chromium.org/753743003

Cr-Commit-Position: refs/heads/master@{#305511}

[modify] http://crrev.com/90590193a9c5b5bc674f1c7680761306ed42c1f1/win8/metro_driver/winrt_utils.cc
[modify] http://crrev.com/90590193a9c5b5bc674f1c7680761306ed42c1f1/win8/viewer/metro_viewer_process_host.cc
[modify] http://crrev.com/90590193a9c5b5bc674f1c7680761306ed42c1f1/win8/viewer/metro_viewer_process_host.h

Project Member

Comment 239 by bugdroid1@chromium.org, Nov 25 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c3841d1c87f5332ba6550ed3b4f113c026b0ce3

commit 1c3841d1c87f5332ba6550ed3b4f113c026b0ce3
Author: dcheng <dcheng@chromium.org>
Date: Tue Nov 25 01:49:27 2014

Disable implicit conversion of scoped_refptr<T> to T* on Windows.

Finally!!!

BUG= 110610 

Review URL: https://codereview.chromium.org/748073004

Cr-Commit-Position: refs/heads/master@{#305558}

[modify] http://crrev.com/1c3841d1c87f5332ba6550ed3b4f113c026b0ce3/base/memory/ref_counted.h
[modify] http://crrev.com/1c3841d1c87f5332ba6550ed3b4f113c026b0ce3/base/win/scoped_comptr.h

Project Member

Comment 240 by bugdroid1@chromium.org, Nov 25 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f4fd73576af0a6632d7477c1da99d6f29dfc00

commit c3f4fd73576af0a6632d7477c1da99d6f29dfc00
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Nov 25 03:54:37 2014

Fix compile break on official Windows builder from disabling scoped_refptr<T> conversions.

BUG= 110610 
R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/751193002

Cr-Commit-Position: refs/heads/master@{#305577}

[modify] http://crrev.com/c3f4fd73576af0a6632d7477c1da99d6f29dfc00/chrome/browser/ui/webui/help/version_updater_win.cc

Project Member

Comment 241 by bugdroid1@chromium.org, Nov 25 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e699b92b064e51a5ffa57debbd5e2e260558b32d

commit e699b92b064e51a5ffa57debbd5e2e260558b32d
Author: dcheng <dcheng@chromium.org>
Date: Tue Nov 25 05:40:56 2014

Remove unneeded #define in ref_counted.h

Now that the implicit conversion to T* can be removed, the preprocessor
define DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR is no longer needed.

BUG= 110610 

Review URL: https://codereview.chromium.org/759503002

Cr-Commit-Position: refs/heads/master@{#305591}

[modify] http://crrev.com/e699b92b064e51a5ffa57debbd5e2e260558b32d/base/memory/ref_counted.h

Project Member

Comment 242 by bugdroid1@chromium.org, Nov 26 2014

Status: Fixed

Comment 244 by ruuda@google.com, Oct 15 2015

I came across a comment in ref_counted.h that mentions this bug, saying “Temporary overloads to facilitate the transition”.

https://chromium.googlesource.com/chromium/src/+/4c664ff1089d19b91e24c85e77adadee0bd3122e/base/memory/ref_counted.h#413

As this bug is marked fixed, what is temporary about it?
Status: Untriaged
Status: Fixed
We should handle any other cleanups in other bugs.
Showing comments 147 - 246 of 246 Older

Sign in to add a comment