New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 110129 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 110361

Blocking:
issue 110127

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

The short cut for Caps Lock should be handled in ash/accelerators/

Project Member Reported by yusukes@chromium.org, Jan 13 2012

Issue description

Currently it's handled in chrome/browser/chromeos/system_key_event_listener.cc by checking the X event loop directly, but for Aura, it'd be better to remove the X dependency by moving the code to ash/accelerators/ since any class except aura::RootWindowHost should not handle an X event directly.

The refactoring is also needed for  crbug.com/110127  (Aura A11y R18 issue).

 
Blocking: 110127
Labels: Mstone-18
Status: Started
Adding Mstone-18 since  Issue 110127  has M18 label.

Comment 3 Deleted

Comment 4 Deleted

Blockedon: 110361
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=118035

------------------------------------------------------------------------
r118035 | yusukes@chromium.org | Tue Jan 17 20:12:14 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_controller_unittest.cc?r1=118035&r2=118034&pathrev=118035
 A http://src.chromium.org/viewvc/chrome/trunk/src/ash/caps_lock_delegate.h?r1=118035&r2=118034&pathrev=118035
 M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_controller.h?r1=118035&r2=118034&pathrev=118035
 M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_controller.cc?r1=118035&r2=118034&pathrev=118035
 M http://src.chromium.org/viewvc/chrome/trunk/src/ash/ash.gyp?r1=118035&r2=118034&pathrev=118035

Handle Caps Lock short cut (Shift+Search) in ash [part 1 of 2].

Currently it's handled in chrome/browser/chromeos/system_key_event_listener.cc by checking the X event loop directly, but for Aura, it'd be better to remove the X dependency by moving the code to ash/accelerators/ since any class except aura::RootWindowHost should not handle an X event directly.

Part 2 of 2: https://chromiumcodereview.appspot.com/9225004/

BUG= 110129 
TEST=ran aura_shell_unittests


Review URL: http://codereview.chromium.org/9242003
------------------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=118103

------------------------------------------------------------------------
r118103 | yusukes@chromium.org | Wed Jan 18 09:22:05 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/keycodes/keyboard_code_conversion_x.cc?r1=118103&r2=118102&pathrev=118103

Do not map XK_Meta_L/R to VKEY_L/RWIN.

BUG= 110361 
BUG= 110129 
TEST=try


Review URL: http://codereview.chromium.org/9241002
------------------------------------------------------------------------
Labels: Iteration-47
Labels: Iteration-48
All open Iteration-47 => Iteration-48
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=118801

------------------------------------------------------------------------
r118801 | yusukes@google.com | Mon Jan 23 22:05:49 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/screen_locker.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/caps_lock_menu_button.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener.h?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_login_display.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard.h?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/input_method_manager.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard.cc?r1=118801&r2=118800&pathrev=118801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=118801&r2=118800&pathrev=118801

Make almost all public functions in XKeyboard pure virtual.

This allows us to create a mock object for the interface, which is necessary for http://codereview.chromium.org/9225004/. Actual function implementations are not changed.

BUG= 110129 
TEST=ran try

Review URL: https://chromiumcodereview.appspot.com/9264004
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=119513

------------------------------------------------------------------------
r119513 | saintlou@chromium.org | Fri Jan 27 15:08:17 PST 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/caps_lock_handler.cc?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/screenshot_taker.h?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener_browsertest.cc?r1=119513&r2=119512&pathrev=119513
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/caps_lock_handler_browsertest.cc?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=119513&r2=119512&pathrev=119513
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/caps_lock_handler.h?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_extra_parts_aura.cc?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=119513&r2=119512&pathrev=119513
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=119513&r2=119512&pathrev=119513

(On behalf of yusukes) Handle Caps Lock short cut (Shift+Search) in ash [part 2 of 2].

Add caps_lock_handler.cc which implements ash::CapsLockDelegate.

Part 1 of 2: http://codereview.chromium.org/9242003
Original review for Part 2 of 2: http://codereview.chromium.org/9225004/ (LGTM'ed by ben@chromium.org and derat@chromium.org)

BUG= 110129 
TEST=ran browser_tests
TBR=ben@chromium.org,derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9297027
------------------------------------------------------------------------
Status: Fixed
This has been landed and is ready to get verified

Comment 13 by laforge@google.com, Feb 29 2012

Labels: -Feature-Aura Feature-Ash
Blockedon: -110361 chromium:110361
Blocking: -110127 chromium:110127
Status: Verified
Been fixed forever.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Blockedon: -chromium:110361 chromium:110361
Blocking: -chromium:110127 chromium:110127
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-18 -Feature-Ash Cr-UI-Shell Cr-UI M-18
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment