New issue
Advanced search Search tips

Issue 110127 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 110129

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

The short cut for Caps Lock (Shift+Search) should be disabled when a11y (spoken feedback) is enabled

Project Member Reported by yusukes@chromium.org, Jan 13 2012

Issue description

What steps will reproduce the problem?

1. turn on a11y
2. press shift+search

What is the expected output?

Since the same short cut is used by ChromeVox, the short cut should not toggle Caps Lock. It should be passed to ChromeVox instead.

What do you see instead?

Caps Lock is toggled.

Please use labels and text to provide additional information.

 
suggestion from dominicc:

Note that we're already changing the behavior of the Search key when accessibility is enabled - see this code in browser_view.cc:

bool BrowserView::AcceleratorPressed(const ui::Accelerator& accelerator) {
#if defined(OS_CHROMEOS)
  // If accessibility is enabled, stop speech and return false so that key
  // combinations involving Search can be used for extra accessibility
  // functionality.
  if (accelerator.key_code() == ui::VKEY_LWIN &&
      g_browser_process->local_state()->GetBoolean(
          prefs::kSpokenFeedbackEnabled)) {
    ExtensionTtsController::GetInstance()->Stop();
    return false;
  }
#endif

Blockedon: 110129
Cc: saintlou@chromium.org
Labels: OS-Chrome
I'll move the code for handling Shift+Search from chrome/browser/chromeos/system_key_event_listener.cc to ash/accelerators/ first ( Issue 110129 ), then add the workaround.

+saintlou
I think this should be fixed in M18, but if this is not the case, please adjust the Mstone label.

Cc: -dominicc@chromium.org dmazz...@chromium.org
sorry! I meant to say dmazzoni@.

Status: Started
Labels: Iteration-47
Labels: Iteration-48
All open Iteration-47 => Iteration-48
Labels: -Pri-2 Pri-1
Marking this as Pri-1 - accessibility is broken without this change, we need to make sure this lands in M18.

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=119523

------------------------------------------------------------------------
r119523 | saintlou@chromium.org | Fri Jan 27 15:16:34 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/caps_lock_handler.cc?r1=119523&r2=119522&pathrev=119523

Ignore Shift+Search when spoken feedback is enabled.

This change depends on http://codereview.chromium.org/9225004/.

BUG= 110127 
TEST=manual, ran browser_tests

Review URL: https://chromiumcodereview.appspot.com/9129016
------------------------------------------------------------------------
Status: Fixed
This has now landed and should be ready for testing
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=123866

------------------------------------------------------------------------
r123866 | dmazzoni@chromium.org | Mon Feb 27 18:03:13 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=123866&r2=123865&pathrev=123866

Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005
------------------------------------------------------------------------
Labels: -Iteration-47 -Iteration-48 Merge-Requested
Status: Started
Requesting merge for r123866 - it applies the same fix to non-Aura, since many machines are still on a non-Aura build.

Comment 14 by kareng@google.com, Feb 28 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 28 2012

Labels: -merge-approved merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=124051

------------------------------------------------------------------------
r124051 | dmazzoni@chromium.org | Tue Feb 28 15:32:20 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=124051&r2=124050&pathrev=124051

Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9514019
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 29 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=124074

------------------------------------------------------------------------
r124074 | karen@chromium.org | Tue Feb 28 16:48:01 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=124074&r2=124073&pathrev=124074

Revert 124051 - Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9514019

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9513017
------------------------------------------------------------------------

Comment 18 by laforge@google.com, Feb 29 2012

Labels: -Feature-Aura Feature-Ash

Comment 19 by ddrew@chromium.org, Mar 20 2012

Labels: -merge-merged-1025 Merge-Requested
Status: Assigned
Re-opening as this is still an open issue that failed to merge.
I'm ready to merge this correctly now. I checked out the full M18 branch and compiled it to make sure.

This ONLY affects Chrome OS, as you can see from the path being changed: chrome/browser/chromeos/system_key_event_listener.cc - it can't possibly affect anything on Win, Mac, or Linux.

Comment 21 by ddrew@chromium.org, Mar 20 2012

We have a special branch 1025_118 and this is now approved to merge to that branch. I'm keeping the merge-requested label applied since this still would need to be merged into 1025.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 20 2012

Labels: merge-merged-1025_118
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=127777

------------------------------------------------------------------------
r127777 | dmazzoni@chromium.org | Tue Mar 20 14:03:01 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025_118/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=127777&r2=127776&pathrev=127777

Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9784001
------------------------------------------------------------------------
Status: Fixed
ChromeOS : 1660.94.0
Chrome: 18.0.1025.0
Status: Verified
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 23 2012

Labels: merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=128521

------------------------------------------------------------------------
r128521 | ddrew@chromium.org | Fri Mar 23 10:47:42 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=128521&r2=128520&pathrev=128521

Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9839062
------------------------------------------------------------------------
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 23 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=128528

------------------------------------------------------------------------
r128528 | dmazzoni@chromium.org | Fri Mar 23 11:09:52 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=128528&r2=128527&pathrev=128528

Revert 128521 - Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

(Needs to be manually merged, will re-land.)

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9839062

TBR=ddrew@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9839063
------------------------------------------------------------------------
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 23 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=128529

------------------------------------------------------------------------
r128529 | dmazzoni@chromium.org | Fri Mar 23 11:11:40 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=128529&r2=128528&pathrev=128529

Merge 123866 - Ignore Shift+Search when spoken feedback is enabled (non-Aura).

BUG= 110127 
BUG=chromium-os:26033
TEST=manual

Review URL: http://codereview.chromium.org/9475005

TBR=dmazzoni@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9845025
------------------------------------------------------------------------

Comment 28 by kareng@google.com, Mar 23 2012

Labels: -Merge-Requested Merge-Merged
Verified on 1660.98.0 beta-channel x86-alex - 18.0.0125.140
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 13 2012

Blockedon: -chromium:110129 chromium:110129
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Accessibility -Mstone-18 -Feature-Ash Cr-UI-Accessibility Cr-UI-Shell Cr-UI M-18
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment