Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 109793 Closing single tab in full screen using "command key + w" closes all tabs
Starred by 4 users Reported by sgoraya@chromium.org, Jan 10 2012 Back to list
Status: Verified
Owner: asvitk...@chromium.org
Closed: Jan 2012
Cc: mac-bugs-priority@chromium.org, pkasting@chromium.org
Components:
OS: Mac
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Chrome Version       : 18.0.1003.0
URLs (if applicable) :
OS version               : 10.6.8
Behavior in Safari 3.x/4.x (if applicable):
Behavior in Firefox 3.x (if applicable):
Behavior in Chrome for Windows: behaves normal closes only one tab in fullscreen

What steps will reproduce the problem?
1.open multiple tabs in chrome window
2.Go to fullscreen 
3.Try closing single tab with " command + w "

What is the expected result?
only single tab should close


What happens instead?
All the tabs are closed

It works fine if we use close button by clicking on it.

 
" Ctrl+ w "  works fine on Windows and linux it closes only single tab.

After running bisect_build i got the results 
"
You are probably looking for build 116144.
CHANGELOG URL:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=116141:116144
Built at revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=116144 "
Comment 2 by k...@google.com, Jan 12 2012
Owner: asvitk...@chromium.org
Status: Assigned
Looks like this is likely from crrev.com/116144
Comment 3 by k...@google.com, Jan 12 2012
Labels: -Pri-2 -Type-Bug Pri-1 Type-Regression Mstone-18
Status: Started
Yes, this is my fault. Looks like fullscreen_window.mm overrides -performClose: and hence misses the custom -performClose: logic in chrome_browser_window.mm.
Project Member Comment 5 by bugdroid1@chromium.org, Jan 13 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=117681

------------------------------------------------------------------------
r117681 | asvitkine@chromium.org | Fri Jan 13 12:30:47 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=117681&r2=117680&pathrev=117681
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/fullscreen_window.mm?r1=117681&r2=117680&pathrev=117681

Fix Cmd-W closing whole window under fullscreen.

This got broken by http://crrev.com/116144, which made Cmd-W
(close tab) route to -performClose:.

However, FullscreenWindow had an override for -performClose:,
resulting in the logic to route Cmd-W to -commandDispatch: not
taking place for fullscreen windows.

Also fixes -[BWC validateUserInterfaceItem:] to correctly disable
IDC_CLOSE_TAB menu items, which was also broken in the same
revision.

BUG= 109793 
TEST=1. Open a fullscreen window with multiple tabs. Hit Cmd-W. A single tab should close.
2. Open a window that doesn't have tabs - e.g. Window -> Task Manager. File -> Close Tab
should be disabled.

Review URL: http://codereview.chromium.org/9187063
------------------------------------------------------------------------
Status: Fixed
This bug is now fixed.

The CL mentions a second issue with the enabled state of "File -> CLose Tab" item, which still seems broken after the CL - I've opened http://crbug.com/110306 to track this separate problem.
I have the same issue. 

Mac OS X 10.6.8
Chrome Dev 18.0.1003.1 dev
Status: Verified
Works fine for 18.0.1010.0. on all os.
Project Member Comment 9 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 10 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Area-UI -Type-Regression -Feature-TabStrip -Mstone-18 Type-Bug-Regression Cr-UI-Browser-TabStrip Cr-UI M-18
Project Member Comment 11 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment