Issue 108599: Hebrew page titles are reversed in header/footer of print

No testcase attached :(

So sorry!

Deleted: Hebrew-Title-Test-Case.html 126 bytes

Hebrew-Title-Test-Case.html 126 bytes View Download

Probably our fault. It's fine in Safari on my Mac.

Also, not WK. This looks like a Skia issue. Chrome 16 on Mac renders the text correctly but Win/Linux/Mac Canary (w/skia) does not.

vandebo: Does Skia know anything about RTL? It seems we have to literally flip the bytes around for Skia to draw it correctly.

Skia doesn't handle RTL, nor does it handle complex text like Thai.  We need to pass the title through the code that does text layout.

Do we just pass a string (Unicode character sequence) to Skia's drawing API in print-preview (header/footer)? If so, vandebo is right.  We have to pass a glyph array (positioned and shaped properly) to Skia instead of a character array. I think we already do this in other places where Skia is used (e.g. Webkit - Uniscribe on Windows, harfbuzz on Linux, tab title drawing, etc). 

xji has done something related for gtk-less UI (for ChromeOS) using Pango.

Yes, we just pass the Unicode string as is to Skia's drawing API in PrintHeaderFooterText() in print_web_view_helper.cc. If you are already familiar with the issue, would you mind taking this bug?

I can take the first shot since I'm also working on related issues on PDF ToUnicode generation.

Update on progress: we are pursuing the path of reusing RenderText to draw the header/footer but we've got some tough drawing issues to overcome.

Need to reevaluate the solution with Skia's i18n support.

Due to the sheer size of blockers, pushing to milestone X.  A partial solution for Windows is already in review.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=135750

------------------------------------------------------------------------
r135750 | arthurhsu@chromium.org | Mon May 07 15:54:20 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=135750&r2=135749&pathrev=135750

Fix RTL and complex script title in print preview header/footer.

Mac fixes is not there yet since RenderText does not support Mac for now.

BUG= 108599 
TEST=print preview pages in different languages


Review URL: https://chromiumcodereview.appspot.com/9111042
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167311

------------------------------------------------------------------------
r167311 | vitalybuka@chromium.org | 2012-11-13T06:21:54.723607Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_win.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_linux.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.h?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_mac.mm?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_settings_initializer.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_job_constants.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/units.cc?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_job_constants.h?r1=167311&r2=167310&pathrev=167311
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/units.h?r1=167311&r2=167310&pathrev=167311
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/print_preview/print_preview_page.html?r1=167311&r2=167310&pathrev=167311

Print headers and footers with WebKit.

Old implementation with gfx::RenderText had issues with fallback fonts. Sandbox does not allow to read required information from registry.

Also WebKit inplementation is smaller and more readable.

BUG= 152893 ,  108599 ,  133548 
TEST=manual: make sure that main content with or without headers is in the same place (default margin is exception). Make sure that any custom margins and paper layout produce reasonable result. If margins are to small, header and footer should be hidden.

Review URL: https://chromiumcodereview.appspot.com/11359020
------------------------------------------------------------------------

Can't reproduce with current chromes. Issue is gone between 20.0.1132.57 and 21.0.1157.0

@vitalybuka - Did you test on all of the platforms?
Windows was indeed fixed a while ago. I believe the issue was kept open for platform parity.

You are right. Mac is OK, but Linux is broken.

r167311 replace code on all platforms. I just have tested Win,Linux and Mac, all work as expected.

I mean Linux was broken before r167311

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168379

------------------------------------------------------------------------
r168379 | vitalybuka@chromium.org | 2012-11-17T04:44:27.527594Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/printing/print_job_constants.cc?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/printing/units.cc?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/printing/print_job_constants.h?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/printing/units.h?r1=168379&r2=168378&pathrev=168379
   A http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/resources/print_preview/print_preview_page.html?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/renderer/print_web_view_helper_win.cc?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/browser_resources.grd?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/renderer/print_web_view_helper_linux.cc?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/renderer/print_web_view_helper.cc?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/renderer/print_web_view_helper.h?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/renderer/print_web_view_helper_mac.mm?r1=168379&r2=168378&pathrev=168379
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/printing/print_settings_initializer.cc?r1=168379&r2=168378&pathrev=168379

Merge 167311 - Print headers and footers with WebKit.

Old implementation with gfx::RenderText had issues with fallback fonts. Sandbox does not allow to read required information from registry.

Also WebKit inplementation is smaller and more readable.

BUG= 152893 ,  108599 ,  133548 
TEST=manual: make sure that main content with or without headers is in the same place (default margin is exception). Make sure that any custom margins and paper layout produce reasonable result. If margins are to small, header and footer should be hidden.

Review URL: https://chromiumcodereview.appspot.com/11359020

TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/11316066
------------------------------------------------------------------------