Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 108228 Chrome 16 breaks some Flash content.
Starred by 599 users Reported by lilli@google.com, Dec 20 2011 Back to list
Status: Fixed
Owner:
Closed: Jan 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Windows
Pri: 1
Type: Compat

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Chrome Version       : 16.0.912.63
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. go to http://chrome.plantsvszombies.com/ using Windows Chrome 16
2. observe the "Missing Plug-in" message

What is the expected result?

You should see a Flash Window showing the game.
What happens instead?

You see a "missing plug-in" message

Please provide any additional information below. Attach a screenshot if
possible.

Note: this is windows specific. Try it on a Mac with the same Chrome and Flash versions and everything's fine.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.63 Safari/535.7



 
pvz_missing.png
619 KB View Download
Comment 1 by lilli@google.com, Dec 20 2011
Labels: -Pri-2 Pri-1
Interestingly it did work in 15 before I updated (I was on an old version on my windows box). Broken on 18 canary, too.
Turns out this may be a more widespread issue. Investigating.

Meanwhile, here's a reduced test case for posterity.
badflash.html
321 bytes View Download
Cc: bauerb@chromium.org jtan@chromium.org jeffreyc@chromium.org nepper@chromium.org
Labels: -Area-Undefined Area-Compat Feature-Flash Feature-Plugins OS-Linux
Also repros on Linux.
Status: Untriaged
Comment 6 by jeffreyc@google.com, Dec 21 2011
Cc: viettrungluu@chromium.org brettw@chromium.org cpu@chromium.org
This seems pretty serious. Brett / Carlos / Trung, could any of you help investigate this?
Summary: Chrome 16 breaks some Flash content. (was: NULL)
Comment 8 by bau...@google.com, Dec 21 2011
 Issue 107978  has been merged into this issue.
Are there UMA stats on how frequently we display the "missing plugin" dialog? If so we can check if there's been a spike recently. I looked at the histograms but couldn't find one that looked relevant. 
Comment 10 by jtan@chromium.org, Dec 21 2011
I had asked for this back in September. See: http://code.google.com/p/chromium/issues/detail?id=98626
On that bug Bernhard indicates we have UMA counts already, if not histograms. Counts would be enough to see a trend increase for a simple thing like this, but the file linked to no longer exists:

http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/renderer/plugin_uma.cc

Does anyone know what became of it, or just what the relevant UMA actions are? I can't find anything that looks relevant in either:

http://codesearch.google.com/#OAMlx_jo-ck/src/chrome/tools/chromeactions.txt&exact_package=chromium&q=autodetectchange&type=cs

or

https://uma.googleplex.com/counts/
Comment 12 by cpu@chromium.org, Dec 21 2011
If you add type="application/x-shockwave-flash" to the embed tag (see comment #3) it works.

I am almost positive this is a webkit regression.

In the time being can somebody add this tag to the PvZ page and test?

Status: Available
Thanks for taking a look, Carlos!

Lily can ask the PopCap folks to try this directly, it's tough to experiment with that on the production page because it needs to be reloaded with the new attribute, which I can't make persist with Dev Tools.
Comment 14 by lilli@google.com, Dec 21 2011
Already done. Waiting on a response from them.
Thanks for looking at this!
-Lilli
Tom, Jeff, your statements indicate that this is a more widespread issue. Can you provide more details?
Owner: cpu@chromium.org
Status: Assigned
Per conversations with cpu@ and laforge@, we suspect this actually isn't a very widespread problem or we'd hear more about it in various feedback channels. We don't believe we're breaking any Top 100 sites, but we also lack good stats to really be sure of this.

Julia, if you & ConOps can keep a close eye out for any complaints related to this we can adjust priority if necessary, but for now we won't do anything drastic.

cpu@ will work on a Chrome fix, and meanwhile any sites this does affect should be able to use the quick workaround in comment #12.
Comment 17 by jtan@chromium.org, Dec 21 2011
Sounds good, will do. 
Tom, sounds good, thanks for the update.
Comment 19 by cpu@chromium.org, Dec 21 2011
I got a CL that fixes the problem

http://codereview.chromium.org/9016030/

I am waiting for green bots to check in. If we want to port it to m16 please let Laforge know.

Comment 20 by cpu@chromium.org, Dec 22 2011
Cc: eseidel@chromium.org jam...@chromium.org
Also jamesr tells me that the following webkit bugs are probably related to this:

https://bugs.webkit.org/show_bug.cgi?id=68789
https://bugs.webkit.org/show_bug.cgi?id=70597

Cc: lafo...@chromium.org
We should port to M16 when convenient, I think, but not urgently unless we get new evidence that this is more widespread. Anthony, wdyt?
Project Member Comment 22 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115468

------------------------------------------------------------------------
r115468 | cpu@chromium.org | Wed Dec 21 18:31:45 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=115468&r2=115467&pathrev=115468

Missing plugin : Fix null mimetype issue in embed tag


In chrome 16,17,18 if you have an embed tag, say flash that has no type information, 
like:

<embed width="100%" name="plugin" src="foo.swf" >

without the type attribute, like  type="application/x-shockwave-flash"

Chrome shows the "missing plugin" element instead of flash.

This uses chrome's knowledge of the mime type instead of just passing webkit's notion of
the mime type which in this case is empty ("").


BUG= 108228 
TEST=see bug for easy repro case.
Review URL: http://codereview.chromium.org/9016030
------------------------------------------------------------------------
Labels: Hotlist-Japan
Glad it's practically fixed.

Adding hotlist-Japan as we received enough JP reports complaining about it.
Mixi had the issue but it seems that they added the mime type.
Will update if I find evidence for an M16 push.
Labels: Mstone-16 Merge-Requested
Mobage on Yahoo Japan (yahoo-mbga.jp) is badly affected by the issue (see Feedback report #128529298).

Considering the importance of this website, I would like to see a merge for the next update to 16.

Note: there are a few other minor to medium size websites affected by the issue too (Feedback reports #125842663, #128732343, #131263473).
Comment 25 by Deleted ...@, Dec 22 2011
I have Chrome 16.0.912.63 on OSX 10.7.2 and whenever I open a page with any kind of flash on it it hangs and then presents me with "Oh, snap!" after a minute or two.  It's been doing this since yesterday afternoon.
Comment 26 by laforge@google.com, Dec 22 2011
Labels: -Merge-Requested Merge-Approved
@pdxVision -- that's troubling, but probably a different bug. Can you file a new bug with:

1. Your exact flash version ("flash plugin" line from about:flash)
2. A page that reproduces the problem

Thanks,
Project Member Comment 28 by bugdroid1@chromium.org, Dec 23 2011
Labels: merge-merged-912
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115677

------------------------------------------------------------------------
r115677 | cpu@chromium.org | Thu Dec 22 19:07:31 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/912/src/chrome/renderer/chrome_content_renderer_client.cc?r1=115677&r2=115676&pathrev=115677

Merge 115468 - Missing plugin : Fix null mimetype issue in embed tag


In chrome 16,17,18 if you have an embed tag, say flash that has no type information, 
like:

<embed width="100%" name="plugin" src="foo.swf" >

without the type attribute, like  type="application/x-shockwave-flash"

Chrome shows the "missing plugin" element instead of flash.

This uses chrome's knowledge of the mime type instead of just passing webkit's notion of
the mime type which in this case is empty ("").


BUG= 108228 
TEST=see bug for easy repro case.
Review URL: http://codereview.chromium.org/9016030

TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/9030004
------------------------------------------------------------------------
Comment 29 by Deleted ...@, Dec 24 2011
Just like comment #25 above, I'm on OSX 10.7.2 and since the update to Chrome 16.0.912.63 I'm also experiencing difficulties with Flash banners. The page doesn't hang like in the previous comment, but the Flash content (in this case banners) is all messed up, being redrawn several times, leaving traces behind and other problems. See attachment. Flash plugin is 11.1.102.55.

Also tested on Safari 5.1.2 and Firefox 9.0.1, all OK. Chrome 15 never had this problem.
chrome.tiff
80.6 KB Download
Comment 30 Deleted
 Issue 108292  has been merged into this issue.
 Issue 103309  has been merged into this issue.
 Issue 103309  has been merged into this issue.
Cc: jam@chromium.org ananta@chromium.org
 Issue 107539  has been merged into this issue.
Comment 35 by Deleted ...@, Dec 27 2011
have the same problem, since the last update flash doesn't work anymore
(missing plug in issiue)
i'm current using windows vista, chrome 16.0.912.63 m
Same problem here. Chrome 16.0.912.63 m.  Some flash sites work, others do not. I have a website where I and at least one user have the problem. Here's the embed code in case it has something to do with that.
<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" 
width="706" height="397" id="minipreviewplayer" name="minipreviewplayer">
<param name="movie" value="flash/129.swf">
<param name="quality" value="High">
<param name="menu" value="false">
<embed id="minipreviewplayer" name="minipreviewplayer" src="flash/129.swf" width="706" height="397">
</object>
Comment 37 by jennc...@gmail.com, Dec 28 2011
Having same flash player issue. Chrome 16.0.912.63. MAC version 10.5.8
Comment 38 by jtan@chromium.org, Dec 28 2011
Labels: Hotlist-ConOps
Just an FYI, we're seeing a large increase in traffic about this issue in the help forum as well. Some additional reports here: http://www.google.com/support/forum/p/Chrome/thread?tid=26d01111bf17a225&hl=en


I guess there hasn't been an M16 update after http://crrev.com/115677? :-/
This issue is already #6 and climbing to #5 for Japan (based on combing through Feedback for Dec. until the 26th).
I believe the plan is to include the fix (crrev.com/115677) in the first M16 Stable refresh in the first week of January.
Okay, then sayonara Chrome, hello again to Firefox, at least until "the first week of Jsanuary." 

This issue has been an intermittent plague for ordinary users for some time. What makes it maddening is Google's inability (or unwillingness) to explain what is happening. What good is it to see "missing plugin" over and over with no further information? Google seems to feel that users deserve nothing more.
Comment 43 by cpu@google.com, Dec 29 2011
bill, the explanation is quite technical, see #22 for the actual reason in c++. If you want less technical, it is basically a bug that gets triggered when the html page underspecifies that the item to show in the page is flash. See comment #12.

So there is plenty of information here, just not in a press-release format.

And to say is a bug is a bit imprecise. One can blame the web developer, as the best practice for embedding flash is not followed, regardless of that page working in other browsers. Or one can blame webkit for reworking how the embed tag works to be in line with the evolving standard, or one can blame html5 for more precisely specifying how the embed tag is to be handled in a cross platform way, regardless of how people actually use the tag in pages out there. Or we can blame chrome for following webkit-latest. And so on.


 Issue 103829  has been merged into this issue.
Labels: Restrict-AddIssueComment-Commit
Comment 46 by jtan@chromium.org, Jan 9 2012
Status: Fixed
The latest update on Stable (version 16.0.912.75) was pushed late last week and has the fix. Ensure you're on it by going to Wrench -> About Google Chrome. 
 Issue 108361  has been merged into this issue.
Comment 48 by bau...@google.com, Jan 11 2012
 Issue 109692  has been merged into this issue.
Comment 49 by k...@google.com, Jan 26 2012
Labels: -Merge-Approved Merge-Unknown
Moving to Unknown for merges in M16, as that ship has sailed.
Comment 50 by k...@google.com, Jan 26 2012
Labels: -Merge-Unknown
Remove unknown label on bugs that have a branch merged label.
Was this fixed on 18 (as trunk) and merged to 16 but not 17?   Bug 115400  and others report this happening again with M17.
Project Member Comment 52 by bugdroid1@chromium.org, Feb 24 2012
Labels: merge-merged-963
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=123510

------------------------------------------------------------------------
r123510 | cpu@chromium.org | Fri Feb 24 10:13:33 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/renderer/chrome_content_renderer_client.cc?r1=123510&r2=123509&pathrev=123510

Merge 115468 - Missing plugin : Fix null mimetype issue in embed tag


In chrome 16,17,18 if you have an embed tag, say flash that has no type information, 
like:

<embed width="100%" name="plugin" src="foo.swf" >

without the type attribute, like  type="application/x-shockwave-flash"

Chrome shows the "missing plugin" element instead of flash.

This uses chrome's knowledge of the mime type instead of just passing webkit's notion of
the mime type which in this case is empty ("").


BUG= 108228 
TEST=see bug for easy repro case.
Review URL: http://codereview.chromium.org/9016030

TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9463019
------------------------------------------------------------------------
 Issue 104217  has been merged into this issue.
Project Member Comment 54 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Type-Bug -Area-Compat -Feature-Flash -Feature-Plugins -Mstone-16 Type-Compat Cr-Content-Plugins-Flash Cr-Content-Plugins M-16
Project Member Comment 55 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 56 by bugdroid1@chromium.org, Apr 6 2013
Labels: Cr-Blink
Project Member Comment 57 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins-Flash Cr-Internals-Plugins-Flash
Project Member Comment 58 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins Cr-Internals-Plugins
Comment 59 by laforge@google.com, Jul 24 2013
Cc: -jeffreyc@chromium.org
Sign in to add a comment