Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 106658 Add a (CQ) to CL committed by the CQ on the commit shortname on buildbot
Starred by 9 users Project Member Reported by mar...@chromium.org, Dec 7 2011 Back to list
Status: WontFix
Owner: ----
Closed: Apr 2014
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 104032



Sign in to add a comment
When the svn revision property 'name' is 'commit-bot', add (CQ) to the commit shortname*. The same shortname is shown on the waterfall and the console.

The svn poller needs to be modified to use --with-all-revprops --xml and revision property parsing needs to be implemented on the buildbot master.
 
maruel: Could you clarify what you meant by commit shortname?

I couldn't find any such property on http://codesearch.google.com/codesearch#OAMlx_jo-ck/tools/build/third_party/buildbot_8_4p1/buildbot/changes/changes.py&l=75 , which is what svnpoller creates.

Did you mean the shortrev? - http://codesearch.google.com/codesearch#OAMlx_jo-ck/tools/build/third_party/buildbot_8_4p1/buildbot/status/web/base.py&l=581  and as used http://codesearch.google.com/codesearch#OAMlx_jo-ck/tools/build/scripts/master/chromium_status_bb8.py&l=95 ? 

The shortrev only seems to be used for the waterfall, not the console, AFAICT. The console still uses the change id ( http://codesearch.google.com/codesearch#OAMlx_jo-ck/tools/build/third_party/buildbot_8_4p1/buildbot/status/web/templates/console.html&l=186 )

Just wanting to understand how you envisioned this / where you envisioned this - a modification to the revision, a modification to the author (change.who), or something else entirely.
Comment 2 by maruel@google.com, Dec 19 2011
See http://codereview.chromium.org/8835004/ for an example. I've put some explanation there.

You can't modify change.who because mails won't work.


Blocking: 104032
Cc: -mar...@chromium.org
Owner: mar...@chromium.org
Project Member Comment 6 by bugdroid1@chromium.org, Mar 10 2013
Blocking: -chromium:104032 chromium:104032
Labels: -Area-Build Build
Labels: -Build-Infrastructure Infra
Comment 8 by mar...@chromium.org, Sep 19 2013
Owner: ----
Looks like this was later effectively reverted in http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.fyi/master.cfg?revision=120344 (http://codereview.chromium.org/9320073).

AFAIK skia has something to detect changes landed using CQ in their buildbot config.

But I'm considering closing this, it's not obvious what are advantages of making this change. Technically one can look at the code review link and see if it was CQ that landed it.
Status: WontFix
Sign in to add a comment