New issue
Advanced search Search tips

Issue 10531 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: May 2009
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Going forward loses history midway at the page that causes redirection

Project Member Reported by yuzo+personal@google.com, Apr 15 2009

Issue description

What steps will reproduce the problem?

1. Open http://www.apple.com
2. Open http://www.hp.com
   The page is redirected to
   http://www.hp.com/#Product
3. Open http://www.cnn.com
4. Click back button 3 times quickly. Slow clicks may let redirection
happen. Now http://www.apple.com should be shown.
5. Click forward button. First, http://www.hp.com is shown.
   Then the page is redirected to http://www.hp.com/#Product.
   Notice that the forward button is now grayed out.
   The user cannot go forward any further. 


What is the expected output? What do you see instead?

In Step 5 above, the forward button is not grayed out.
Another click on forward button should bring up http://www.cnn.com

I think Chrome should behave the same way as IE7/FF3.

I tested this only with Windows XP.

IE7: Good: Clicks on forward button causes the following transition:
http://www.apple.com -> http://www.hp.com/#Product -> http://www.cnn.com
(Note: http://www.hp.com doesn't show up.)

FF3: Good: Same as IE7
Safari 4 Public Beta: Bad: Same as Chrome


Please use labels and text to provide additional information.

 
Labels: Mstone-X
Status: Available
Status: Started

Comment 3 by bugdro...@gmail.com, May 13 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15950 

------------------------------------------------------------------------
r15950 | maruel@chromium.org | 2009-05-13 06:22:45 -0700 (Wed, 13 May 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/HistoryHelper.js?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test1.html?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test2.html?r1=15950&r2=15949
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=15950&r2=15949

This is the successor to http://codereview.chromium.org/67150

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG= 9663 , 10531 

Tested: unit_tests, ui_tests, manually.

Patch contributed by Yuzo Fujishima <yuzo@google.com>

Review: http://codereview.chromium.org/100245
------------------------------------------------------------------------

Comment 4 by prog...@gmail.com, May 13 2009

is this related to  Issue 11355 ?
it's not about back&forward but it is about history+redirections
 Issue 11355  is probably not related to this.
(At least it is not fixed by the change listed above.)
Status: Fixed
Status: Verified
Verified in Chrome 2.0.181.1 (Official Build 16409) and Chromium 2.0.182.0 (Developer
Build 16485).

Comment 8 by yvr...@gmail.com, Jul 14 2009

Works fine on stable 2.0.172.38.
Comment 8 is from me.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21501 

------------------------------------------------------------------------
r21501 | laforge@chromium.org | 2009-07-23 19:00:09 -0700 (Thu, 23 Jul 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.cc?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.h?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/HistoryHelper.js?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test1.html?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test2.html?r1=21501&r2=21500
   D /branches/172/src/chrome/test/data/History/history_length_test_page_1.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_2.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_3.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/ui/history_uitest.cc?r1=21501&r2=21500

Revert 19923 - Merge r15950.

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG= 9663 , 10531 

Tested: unit_tests, ui_tests, manually.

TBR=mal@chromium.org

Review URL: http://codereview.chromium.org/159329
------------------------------------------------------------------------

Comment 11 by Deleted ...@, Sep 3 2010

This problem occurs even when redirection is not involved.  Clicking the back or forward buttons too fast causes Chrome to "lose" pages in the history.  Once they are "lost", even slow forward/back movement cannot return you to the "lost" page.

For example, I navigate at a leisurely pace from pages A to B to C to D, using links within each page to get to the next [I am certain there is no redirection involved, as these pages are all part of the same website and tree hierarchy].  If I want to go from D back to B, and I hit the back button twice very rapidly, it will go back to A, as if B never existed.  I can then hit the forward button twice (at any speed), and it will navigate A -> C -> D.  I can sgain hit the back button twice (at any speed), and it will go from D-> C -> A.  I can do this repeatedly once page B has been lost from the history.  It is as if I never visited page B at all.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment