Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 104170 [Mac OS - Regression] Best-fit-window-zoom doesn't work anymore
Starred by 4 users Project Member Reported by meh...@chromium.org, Nov 14 2011 Back to list
Status: Verified
Owner:
Closed: Jan 2012
Cc:
Components:
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Chromium Version: 17.0.939.0 (Entwickler-Build 109903 Mac OS X)
OS version: Mac OS 10.6.8
Behavior in Safari 3.x/4.x (if applicable): okay
Behavior in Firefox 3.x (if applicable): not available
Behavior in Chrome for Windows: not available

What steps will reproduce the problem?
1. e.g. go to http://code.google.com/p/chromium/issues/list
2. shrink the window to very small size
3. click on the green plus bubble to zoom the window to best-fit

What is the expected result?
The window should zoom to best-fit. The blue horizontal scrollbar should not be visible

What happens instead?
It doesn't zoom to best-fit. The blue scrollbar is still to see.

*** Screencast attached ***

The regression-range is between build 99865 and build 99880.

Not sure, which change has broke this. Two changes have touched some cocoa stuff:

http://codereview.chromium.org/7831051 (erg@) and http://codereview.chromium.org/7537030 (jianli@)

Maybe caused by one of them??

This is broken in Chrome 15 stable, but this should be at least a blocker for Mstone 16 Stable.

Thanks and regards
Mehmet

 
screencast.mov
8.8 MB Download
Comment 1 by rsesek@chromium.org, Nov 14 2011
Owner: jianli@chromium.org
Status: Assigned
Comment 2 by jianli@chromium.org, Nov 30 2011
I can't repro this with latest beta build 16.0.912.41 or developer build 17.0.948.0.
Comment 3 by laforge@google.com, Nov 30 2011
Labels: -Mstone-16 -ReleaseBlock-Stable
Owner: meh...@chromium.org
Status: WontFix
Assigning back to the reporter, and marking as WontFix (couldn't reproduce).  Please feel free to re-open if it's still an issue.
Cc: lafo...@chromium.org
Hmmm.... I still see this issue with Chromium 17.0.957.0 (112491) on Mac OS 10.6.8 and 10.7.2.

@jianli / laforge: Have you a chance to test it on small screen like on a 13'' MacBook ?

Thanks in advance.
Status: Available
Re-opening. I can repro this in Chrome Mac 18.0.1003.0 canary, per repro steps.

Clicking green zoom-best-fit button doesn't size the window wide enough to get rid of the horizontal scrollbar.

It works correctly in Safari.

Mehmet, can you bisect builds to find when this started happening? Thanks!
Comment 6 by meh...@chromium.org, Jan 10 2012
Cc: asvitk...@chromium.org
Owner: ----
Thanks for confirming this issue, Alexei.

Please try these two build: 99865 (okay) and 99880 (fail)

http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?path=Mac/99865/

http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?path=Mac/99880/

I am not sure, which build in this range has broke this: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=&range=99865%3A99880&mode=html

Do you have an idea?
Thanks.

Comment 7 by jianli@chromium.org, Jan 10 2012
Owner: jianli@chromium.org
Status: Assigned
I will take a look.
Comment 8 by meh...@chromium.org, Jan 10 2012
Thanks :-)
Project Member Comment 9 by bugdroid1@chromium.org, Jan 11 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=117260

------------------------------------------------------------------------
r117260 | jianli@chromium.org | Wed Jan 11 11:37:34 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.mm?r1=117260&r2=117259&pathrev=117260
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.h?r1=117260&r2=117259&pathrev=117260
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h?r1=117260&r2=117259&pathrev=117260

Fix bug 104170: [Mac OS] Best-fit-window-zoom doesn't work anymore

BUG= 104170 
TEST=Manual test by following repro steps in the bug


Review URL: http://codereview.chromium.org/9158026
------------------------------------------------------------------------
Labels: Mstone-17 ReleaseBlock-Beta Merge-Requested
Comment 11 by k...@google.com, Jan 13 2012
Labels: -ReleaseBlock-Beta -Merge-Requested Merge-Approved
Project Member Comment 12 by bugdroid1@chromium.org, Jan 13 2012
Labels: -merge-approved merge-merged-963
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=117573

------------------------------------------------------------------------
r117573 | jianli@chromium.org | Thu Jan 12 16:47:48 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/browser/ui/cocoa/browser_window_cocoa.h?r1=117573&r2=117572&pathrev=117573
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/browser/ui/cocoa/browser_window_cocoa.mm?r1=117573&r2=117572&pathrev=117573
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/browser/tab_contents/tab_contents_view_mac.h?r1=117573&r2=117572&pathrev=117573

Merge 117260 - Fix bug 104170: [Mac OS] Best-fit-window-zoom doesn't work anymore

BUG= 104170 
TEST=Manual test by following repro steps in the bug


Review URL: http://codereview.chromium.org/9158026

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/9197020
------------------------------------------------------------------------
Many thanks, jianli !!! Works fine again in Canary !!!
Status: Fixed
Project Member Comment 15 by bugdroid1@chromium.org, Jan 14 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=117802

------------------------------------------------------------------------
r117802 | avi@chromium.org | Sat Jan 14 10:17:23 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.mm?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.h?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h?r1=117802&r2=117801&pathrev=117802
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=117802&r2=117801&pathrev=117802

Fix window zoom in a sane way, remove nasty casts.

BUG= 110208 ,  104170 
TEST=window zoom should work, as in bug 104170

Review URL: http://codereview.chromium.org/9215002
------------------------------------------------------------------------
Comment 16 by Deleted ...@, Jan 17 2012
Thanks for fixing this bug, I have been annoyed by this bug for years, now I am using Chrome18.0.1003.01, still found this bug, hope it will be fixed in next release
Status: Verified
Verified for 17.0.963.38 and Canary (18.0.1011.1).It works fine.
Project Member Comment 18 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 19 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Area-UI -Type-Regression -Feature-Browser -Mstone-17 Type-Bug-Regression Cr-UI Cr-UI-Browser-Core M-17
Project Member Comment 20 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment