New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 102431 link

Starred by 9 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Google search app icon violates guidelines

Project Member Reported by est...@chromium.org, Oct 31 2011

Issue description

1. it is too big - square icons should not use up the full 128x128 px but instead be 96x96

2. it has a white background instead of transparent

3. it doesn't look nearly as awesome as any of the other google app icons

since this is now a default app (at least I'm assuming that's why it showed up in my NTP without warning) I'm marking it as a release blocker
 
ugly_default_icon.png
97.4 KB View Download
Labels: -Mstone-16 -ReleaseBlock-Stable Mstone-17
 bug 102502  --- I guess it's been removed?
Labels: Feature-Apps Feature-NewTabPage
Cc: tmc...@chromium.org odean@chromium.org
Labels: -Mstone-17 Mstone-16 ReleaseBlock-Stable
Actually, a fix is currently in the works which, if successful, will allow us to ship all 3 default apps in M16.
Cc: alcor@google.com
There was an email thread on this, and I believe Tyler (odean@) is going to update the icon.
hey Tyler, did the Search app icon get updated? Can we close this bug?
Cc: ziga@chromium.org anantica@google.com
I pinged Ziga and Anantica about this too.

Comment 8 by ziga@chromium.org, Nov 8 2011

I'll update the icon.

Comment 9 by ziga@chromium.org, Nov 8 2011

Status: Fixed
New icon is in the Web Store.
great, thanks all
Ziga: Can you please provide the URL to the crx?  Thanks.
Status: Started
Changing status back to started since the new crx is not yet committed.

Status: Fixed
If the icon in the crx itself is up to date and within guidelines let's close this out.
Status: Assigned
Still looks wrong when I create a new profile on 17.0.935.0 canary (screenshot attached).

Can someone (Ziga?) confirm what is remaining that needs to be done?

thanks,
Jeff
screenshot.png
23.1 KB View Download

Comment 15 Deleted

Comment 16 by ziga@chromium.org, Nov 10 2011

http://codereview.chromium.org/8480026/ has the new crx.  Roger, please close this once it's submitted.
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 11 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=109669

------------------------------------------------------------------------
r109669 | rogerta@chromium.org | Fri Nov 11 11:13:15 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/default_apps/search.crx?r1=109669&r2=109668&pathrev=109669
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/default_apps/external_extensions.json?r1=109669&r2=109668&pathrev=109669

Fix the default search app icon to conform with webstore guidlines.

BUG= 102431 
TEST=Make sure that the default search app's icon meets the criteria listed
in the bug description
Review URL: http://codereview.chromium.org/8480026
------------------------------------------------------------------------
Labels: Merge-Requested
Status: Fixed

Comment 19 by laforge@google.com, Nov 11 2011

Labels: -Merge-Requested Merge-Approved
LGTM.  Do me a favor though, if you do use drover to do this merge...(sometimes it doesn't handle binary merges well)

In Shell #1:

drover --merge 109669 --branch 912
... (all through the upload prompt)

In Shell #2:

cd <dir_where_you_ran_drover_from>/drover_109290_912/src/chrome/browser/resources/default_apps/
copy the search.crx directly there

Back to Shell #1:

Y - Upload
Y - Commit



Comment 20 by laforge@google.com, Nov 11 2011

(minor correction)

cd <dir_where_you_ran_drover_from>/drover_109669_912/src/chrome/browser/resources/default_apps/
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 14 2011

Labels: merge-merged-912
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=109954

------------------------------------------------------------------------
r109954 | rogerta@chromium.org | Mon Nov 14 13:13:52 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/912/src/chrome/browser/resources/default_apps/external_extensions.json?r1=109954&r2=109953&pathrev=109954
 M http://src.chromium.org/viewvc/chrome/branches/912/src/chrome/browser/resources/default_apps/search.crx?r1=109954&r2=109953&pathrev=109954

Merge 109669 - Fix the default search app icon to conform with webstore guidlines.

BUG= 102431 
TEST=Make sure that the default search app's icon meets the criteria listed
in the bug description
Review URL: http://codereview.chromium.org/8480026

TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/8544002
------------------------------------------------------------------------
Status: Verified
Verified on Win7/64 bit, Mac OSX - 10.6.8, Linux Ubuntu - 10.04 - 16.0.912.41 (Official Build 110024)
Correct Google Search App Icon.PNG
175 KB View Download
beautiful :)
I personally think that the one I made is more beautiful...
Capturar.PNG
189 KB View Download

Comment 25 by k...@google.com, Jan 26 2012

Labels: -Merge-Approved Merge-Unknown
Moving to Unknown for merges in M16, as that ship has sailed.

Comment 26 by k...@google.com, Jan 26 2012

Labels: -Merge-Unknown
Remove unknown label on bugs that have a branch merged label.
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-16 -Feature-Apps -Feature-NewTabPage Cr-UI-Browser-NewTabPage Cr-Platform-Apps Cr-UI M-16
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment