New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2011
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 100439: FFmpeg downloads entire WebM cluster during call to av_find_stream_info()

Reported by scherkus@chromium.org, Oct 15 2011 Project Member

Issue description

This has a *major* impact on start up latency.

The fix is to only read what we actually need and defer downloading and parsing of additional blocks inside a cluster until we actually need them.
 

Comment 1 by bugdroid1@chromium.org, Oct 15 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105638

------------------------------------------------------------------------
r105638 | scherkus@chromium.org | Fri Oct 14 20:50:34 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/source/patched-ffmpeg/libavformat/matroskadec.c?r1=105638&r2=105637&pathrev=105638
 A http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/patches/ugly/41_matroska_cluster_incremental.patch?r1=105638&r2=105637&pathrev=105638
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/patches/README?r1=105638&r2=105637&pathrev=105638

Parse matroska clusters incrementally as opposed to all at once.

While the patch is ugly, it prevents us from downloading the entire first cluster during the call to av_find_stream_info(). As a result, start up latency is greatly improved.

BUG= 100439 
TEST=start up time, seeking, everything works

Review URL: http://codereview.chromium.org/8296016
------------------------------------------------------------------------

Comment 3 by bugdroid1@chromium.org, Oct 15 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105642

------------------------------------------------------------------------
r105642 | scherkus@chromium.org | Fri Oct 14 21:54:32 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/binaries/win/avformat-53.dll?r1=105642&r2=105641&pathrev=105642
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/binaries/win/avcodec-53.dll?r1=105642&r2=105641&pathrev=105642
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/binaries/win/avutil-51.dll?r1=105642&r2=105641&pathrev=105642

Windows Chromium FFmpeg binaries for r105638.

This time stripped so they're ~100KB smaller.

BUG= 100439 

------------------------------------------------------------------------

Comment 4 by bugdroid1@chromium.org, Oct 15 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105644

------------------------------------------------------------------------
r105644 | scherkus@chromium.org | Fri Oct 14 22:07:36 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=105644&r2=105643&pathrev=105644

Updating FFmpeg to r105642.

BUG= 100439 

Review URL: http://codereview.chromium.org/8301023
------------------------------------------------------------------------

Comment 5 by scherkus@chromium.org, Oct 16 2011

Labels: Feature-Media-Network Merge-Requested ImportantForVideo
Status: Fixed
Works fantastic on 16.0.909.0 canary and Chromium nightlies from r105644 or later.

Comment 6 by kareng@google.com, Oct 17 2011

Labels: -Merge-Requested Merge-Approved
thanks for checking!

Comment 7 by scherkus@chromium.org, Oct 17 2011

Status: Verified

Comment 8 by bugdroid1@chromium.org, Oct 17 2011

Project Member
Labels: -merge-approved merge-merged-874
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105896

------------------------------------------------------------------------
r105896 | scherkus@chromium.org | Mon Oct 17 13:21:31 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/874/src/build/common.gypi?r1=105896&r2=105895&pathrev=105896

Partial merge of r105149 into 874 branch in order to merge fixes for bugs  99652  and  100439 .

A gyp variable declaration was moved from third_party/ffmpeg/ffmpeg.gyp to build/common.gypi.

BUG= 99652 ,  100439 
TBR=kareng

------------------------------------------------------------------------

Comment 9 by scherkus@chromium.org, Oct 17 2011

Merged into 874 as r18655.

Comment 10 by scherkus@chromium.org, Oct 19 2011

Labels: -ImportantForVideo Hotlist-NeededForVideo

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 12 by bugdroid1@chromium.org, Nov 14 2012

Project Member
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=18599

------------------------------------------------------------------------
r18599 | scherkus@google.com | 2011-10-15T05:10:09.329178Z

------------------------------------------------------------------------

Comment 13 by bugdroid1@chromium.org, Nov 14 2012

Project Member
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=18655

------------------------------------------------------------------------
r18655 | scherkus@google.com | 2011-10-17T20:34:50.777565Z

------------------------------------------------------------------------

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-WebKit -Mstone-15 -Feature-Media-Network Cr-Content Cr-Internals-Media-Network M-15

Comment 15 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 16 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content Cr-Blink

Sign in to add a comment