New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14



Sign in to add a comment

Parsing of proxy configuration is not standard compliant

Project Member Reported by johnchen@chromium.org, Aug 9

Issue description

ChromeDriver does not parse proxy configuration capability (https://www.w3.org/TR/webdriver/#proxy) in a standard-compliant way. For example, the standard indicates that the value for "noProxy" should be an array, but ChromeDriver expects it to be a string.
 
Project Member

Comment 1 by johnchen@chromium.org, Sep 14

Owner: johnchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b25ac3d1c6342ef8af34041dd545067b8f815bf

commit 1b25ac3d1c6342ef8af34041dd545067b8f815bf
Author: John Chen <johnchen@chromium.org>
Date: Fri Sep 14 22:19:28 2018

[ChromeDriver] W3C compliant parsing proxy setting

Update parsing of proxy settings in session capabilities, for W3C
compliance. Changes include:
* Handle noProxy containing a list of strings.
* Handle socksProxy and socksVersion.
* Return kInvalidArgument for errors.

Bug:  chromedriver:2537 
Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca
Reviewed-on: https://chromium-review.googlesource.com/1226096
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591496}
[modify] https://crrev.com/1b25ac3d1c6342ef8af34041dd545067b8f815bf/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/1b25ac3d1c6342ef8af34041dd545067b8f815bf/chrome/test/chromedriver/capabilities_unittest.cc

Project Member

Comment 3 by johnchen@chromium.org, Sep 14

Labels: ChromeDriver-2.43 ToBeReleased
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18 (5 days ago)

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad

commit b0c36d86f1a633520a93efa4d1f3b75c5c5849ad
Author: John Chen <johnchen@chromium.org>
Date: Tue Sep 18 02:06:11 2018

[ChromeDriver] W3C compliant parsing proxy setting

Update parsing of proxy settings in session capabilities, for W3C
compliance. Changes include:
* Handle noProxy containing a list of strings.
* Handle socksProxy and socksVersion.
* Return kInvalidArgument for errors.

Bug: 884755,  chromedriver:2537 
Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca
Reviewed-on: https://chromium-review.googlesource.com/1226096
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591496}(cherry picked from commit 1b25ac3d1c6342ef8af34041dd545067b8f815bf)
Reviewed-on: https://chromium-review.googlesource.com/1228303
Cr-Commit-Position: refs/branch-heads/3538@{#469}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad/chrome/test/chromedriver/capabilities_unittest.cc

Sign in to add a comment