New issue
Advanced search Search tips

Issue 1997 link

Starred by 34 users

Issue metadata

Status: Started
Owner:

Blocking:
issue 2536



Sign in to add a comment

New Session is not spec compliant

Project Member Reported by kereliuk@chromium.org, Sep 8 2017

Issue description

We need to validate capabilities as is indicated in the spec:
https://w3c.github.io/webdriver/webdriver-spec.html#new-session


 
Project Member

Comment 1 by johnchen@chromium.org, Aug 3

Labels: StandardsCompliance
Blocking: 2536
Project Member

Comment 3 by johnchen@chromium.org, Aug 22

Labels: Pri-1
Owner: ----
Project Member

Comment 4 by johnchen@chromium.org, Sep 24

Owner: johnchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d39029faf55d93a7e62c30ea9a244e48e0b132

commit e9d39029faf55d93a7e62c30ea9a244e48e0b132
Author: John Chen <johnchen@chromium.org>
Date: Tue Sep 25 17:36:23 2018

[ChromeDriver] Expand Capabilities for W3C compliance

This CL is one step in making InitSession command W3C compliant.
It expands Capabilities object to include all capabilities that are
specified in the W3C spec. Changes include:
* Re-ordered fields in Capabilities into W3C section and ChromeDriver
  specific section. Entries in W3C section are listed in the same
  order as they appear in W3C spec.
* Added browserName, browserVersion, and platformName capabilities.
  They will be needed for proper firstMatches handling.
* Added fields needed for timeouts capability. Parsing and using of
  these fields will be added in an upcoming CL.
* Replaced legacy name unexpected_alert_behaviour with W3C-compliant
  name unhandled_prompt_behavior.
* Modified Capabilities::Parse to accept all capability values,
  including those not yet supported by ChromeDriver. Added another
  method Capabilities::IsSupported to check for unsupported options.
  This is needed for upcoming W3C-compliant capability validation.

Bug: chromedriver:1997
Change-Id: I5f53341cf47f77a1853f40028b1efe6f0b69c611
Reviewed-on: https://chromium-review.googlesource.com/1241213
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593989}
[modify] https://crrev.com/e9d39029faf55d93a7e62c30ea9a244e48e0b132/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/e9d39029faf55d93a7e62c30ea9a244e48e0b132/chrome/test/chromedriver/capabilities.h
[modify] https://crrev.com/e9d39029faf55d93a7e62c30ea9a244e48e0b132/chrome/test/chromedriver/session.h
[modify] https://crrev.com/e9d39029faf55d93a7e62c30ea9a244e48e0b132/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/e9d39029faf55d93a7e62c30ea9a244e48e0b132/chrome/test/chromedriver/window_commands.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886942637f14189c6bc2a1333c920dfbb93680cf

commit 886942637f14189c6bc2a1333c920dfbb93680cf
Author: John Chen <johnchen@chromium.org>
Date: Fri Nov 09 04:31:14 2018

[ChromeDriver] W3C compliant unknown capability handling

Per W3C spec, unrecognized capabilities should trigger invalid argument
error, instead of being silently ignored.

Bug: chromedriver:1997
Change-Id: I84b2a888ad97d709737368b9394c8efdd475bf3a
Reviewed-on: https://chromium-review.googlesource.com/c/1325562
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606733}
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/capabilities.h
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/capabilities_unittest.cc
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/log_replay/client_replay.py
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/log_replay/client_replay_unittest.py
[modify] https://crrev.com/886942637f14189c6bc2a1333c920dfbb93680cf/chrome/test/chromedriver/session_commands.cc

Sign in to add a comment