New issue
Advanced search Search tips

Issue 1994 link

Starred by 11 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 5



Sign in to add a comment

XML special case of Get Element CSS Value is not handled as per spec

Project Member Reported by kereliuk@chromium.org, Sep 8 2017

Issue description

The spec states we must return "" if the doc type is xml, we don't handle this case.

https://w3c.github.io/webdriver/webdriver-spec.html#get-element-css-value
 
Project Member

Comment 1 by kereliuk@chromium.org, Jul 26

Owner: ----
Status: Untriaged (was: Unconfirmed)
Project Member

Comment 2 by johnchen@chromium.org, Jul 31

Labels: StandardsCompliance Pri-2
Status: Available (was: Untriaged)
Project Member

Comment 3 by johnchen@chromium.org, Oct 17

Owner: buldina@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by johnchen@chromium.org, Oct 17

The following Python code snippet can repro this issue:

from selenium import webdriver
driver = webdriver.Chrome()
driver.get('https://www.w3schools.com/xml/note.xml')
print(driver.find_element_by_tag_name('body').value_of_css_property('display'))

With current ChromeDriver (up to version 2.43), the last statement prints "block", while a correct implementation should print an empty string.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f393ab48d68b4b17d4817831b7092afa40d75359

commit f393ab48d68b4b17d4817831b7092afa40d75359
Author: Tatiana Buldina <buldina@chromium.org>
Date: Mon Nov 05 22:12:06 2018

[ChromeDriver] XML special case in Get Element CSS Value

Bug:  chromedriver:1994 
Change-Id: Ic15edd6634d5a8cc118703a86155a90eda602a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1292407
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605490}
[modify] https://crrev.com/f393ab48d68b4b17d4817831b7092afa40d75359/chrome/test/chromedriver/element_commands.cc
[modify] https://crrev.com/f393ab48d68b4b17d4817831b7092afa40d75359/chrome/test/chromedriver/element_util.cc
[modify] https://crrev.com/f393ab48d68b4b17d4817831b7092afa40d75359/chrome/test/chromedriver/element_util.h

Labels: ToBeReleased ChromeDriver-2.44
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
The fix is verified

Sign in to add a comment