New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit 23 days ago
Closed: Aug 31



Sign in to add a comment

Fullscreen Window command not spec compliant

Project Member Reported by kereliuk@chromium.org, Sep 8 2017

Issue description

We do not return the correct payload in our current implementation.

According to spec, we must:
Return success with the JSON serialization of the current top-level browsing context’s window rect.

Currently we return null.

https://w3c.github.io/webdriver/webdriver-spec.html#fullscreen-window
 
_driver.Manage().Window.FullScreen(); gives null reference exception (in Google Chrome with C#.Net).

It looks like the implementation is not proper.

Test execution result attached.

Result Message:	
System.NullReferenceException : Object reference not set to an instance of an object.
TearDown : System.NullReferenceException : Object reference not set to an instance of an object.


Project Member

Comment 2 by johnchen@chromium.org, Aug 3

Labels: StandardsCompliance
Project Member

Comment 3 by johnchen@chromium.org, Aug 22

Labels: Pri-2
Owner: ----
Project Member

Comment 4 by cwinstanley@google.com, Aug 31

Owner: cwinstanley@google.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e97421916152cd3a56d75e254d29e8bff574180

commit 0e97421916152cd3a56d75e254d29e8bff574180
Author: Cole Winstanley <cwinstanley@google.com>
Date: Fri Aug 31 18:58:44 2018

[ChromeDriver] Fix Maximize Window and Full Screen

Make the MaximizeWindow and FullScreen commands return the serialized
window rectangle to comply with W3C spec. Changed tests to tests this
behavior and to be more robust overall.

Bug:  chromedriver:1993 
Change-Id: Ie9656e14fc67b1f4541055a8f41e6fbc109cdd98
Reviewed-on: https://chromium-review.googlesource.com/1198444
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Cr-Commit-Position: refs/heads/master@{#588103}
[modify] https://crrev.com/0e97421916152cd3a56d75e254d29e8bff574180/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/0e97421916152cd3a56d75e254d29e8bff574180/chrome/test/chromedriver/client/command_executor.py
[modify] https://crrev.com/0e97421916152cd3a56d75e254d29e8bff574180/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/0e97421916152cd3a56d75e254d29e8bff574180/chrome/test/chromedriver/test/run_py_tests.py

Project Member

Comment 6 by cwinstanley@google.com, Aug 31

Labels: ChromeDriver-2.42
Status: Fixed (was: Started)

Sign in to add a comment