New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:



Sign in to add a comment
link

Issue 1990: Close Window return value does not conform with spec

Reported by kereliuk@chromium.org, Sep 8 2017 Project Member

Issue description

According to the spec:
Return the result of running the remote end steps for the Get Window Handles command

We currently do not return anything.

https://w3c.github.io/webdriver/webdriver-spec.html#close-window
 

Comment 1 by cwinstanley@google.com, Jun 26 2018

Project Member
Cc: johnchen@chromium.org
Components: WebDriver
Owner: cwinstanley@google.com
Status: Started (was: Available)

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030

commit be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030
Author: Cole Winstanley <cwinstanley@google.com>
Date: Fri Jun 29 00:00:16 2018

[ChromeDriver] Making CloseWindow W3C Compliant

Making CloseWindow W3C compliant by returning the result of
GetWindowHandles. Modified testCloseWindow in run_py_tests.py
to test this conformance.

Bug:  chromedriver:1990 
Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431
Reviewed-on: https://chromium-review.googlesource.com/1115813
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Cr-Commit-Position: refs/heads/master@{#571334}
[modify] https://crrev.com/be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030/chrome/test/chromedriver/test/run_py_tests.py

Comment 3 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a73f750e5926164aa3ecf077ca5aab8c4eeb28e

commit 7a73f750e5926164aa3ecf077ca5aab8c4eeb28e
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 15:27:49 2018

Revert "[ChromeDriver] Making CloseWindow W3C Compliant"

This reverts commit be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030.

Reason for revert: Suspecting that this patch caused major flaky of chromedriver_py_tests on win

Original change's description:
> [ChromeDriver] Making CloseWindow W3C Compliant
> 
> Making CloseWindow W3C compliant by returning the result of
> GetWindowHandles. Modified testCloseWindow in run_py_tests.py
> to test this conformance.
> 
> Bug:  chromedriver:1990 
> Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431
> Reviewed-on: https://chromium-review.googlesource.com/1115813
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Cole Winstanley <cwinstanley@google.com>
> Cr-Commit-Position: refs/heads/master@{#571334}

TBR=crouleau@chromium.org,johnchen@chromium.org,kereliuk@chromium.org,cwinstanley@google.com

Change-Id: Iae1e975140df2381d21a271fcfd9b5651b6ac4ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromedriver:1990 , 859079
Reviewed-on: https://chromium-review.googlesource.com/1120466
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571485}
[modify] https://crrev.com/7a73f750e5926164aa3ecf077ca5aab8c4eeb28e/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/7a73f750e5926164aa3ecf077ca5aab8c4eeb28e/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/7a73f750e5926164aa3ecf077ca5aab8c4eeb28e/chrome/test/chromedriver/test/run_py_tests.py

Comment 4 by bugdroid1@chromium.org, Jun 29 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d47e2e3c448b8ef0df05bc42597c7c456a8ef88a

commit d47e2e3c448b8ef0df05bc42597c7c456a8ef88a
Author: Cole Winstanley <cwinstanley@google.com>
Date: Fri Jun 29 21:36:18 2018

Reland "[ChromeDriver] Making CloseWindow W3C Compliant"

This is a reland of be44dc6b6bc15c5d49f589a0a4d4568e3d9d4030

Original change's description:
> [ChromeDriver] Making CloseWindow W3C Compliant
> 
> Making CloseWindow W3C compliant by returning the result of
> GetWindowHandles. Modified testCloseWindow in run_py_tests.py
> to test this conformance.
> 
> Bug:  chromedriver:1990 
> Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431
> Reviewed-on: https://chromium-review.googlesource.com/1115813
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Cole Winstanley <cwinstanley@google.com>
> Cr-Commit-Position: refs/heads/master@{#571334}

Bug:  chromedriver:1990 
Change-Id: Iac9b60f09aeb697151077410dbcb408dbba420c2
Reviewed-on: https://chromium-review.googlesource.com/1120696
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Cr-Commit-Position: refs/heads/master@{#571639}
[modify] https://crrev.com/d47e2e3c448b8ef0df05bc42597c7c456a8ef88a/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/d47e2e3c448b8ef0df05bc42597c7c456a8ef88a/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/d47e2e3c448b8ef0df05bc42597c7c456a8ef88a/chrome/test/chromedriver/test/run_py_tests.py

Comment 5 by cwinstanley@google.com, Jun 29 2018

Project Member
Labels: ToBeReleased ChromeDriver-2.41
Status: Fixed (was: Started)

Comment 6 by johnchen@chromium.org, Jul 30 2018

Project Member
Labels: -ToBeReleased

Sign in to add a comment