New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018



Sign in to add a comment
link

Issue 1940: Many window command endpoints are unimplemented in Chromedriver

Reported by kereliuk@chromium.org, Aug 16 2017 Project Member

Issue description

The following spec endpoints are unimplemented in Chromedriver:

POST /session/{session id}/window/minimize

POST /session/{session id}/window/rect

POST /session/{session id}/window/fullscreen

GET /session/{session id}/window/rect

POST /session/{session id}/window/maximize

See spec for details: https://w3c.github.io/webdriver/webdriver-spec.html#list-of-endpoints
 

Comment 1 by gmanikpure@chromium.org, Aug 18 2017

Project Member
Labels: Pri-2
Status: Available (was: Untriaged)

Comment 2 by kereliuk@chromium.org, Sep 8 2017

Project Member
Fullscreen was implemented by gmanikpure@

https://chromium-review.googlesource.com/c/chromium/src/+/617478

Comment 4 by bugdroid1@chromium.org, Oct 23 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3

commit 3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3
Author: Jonathon Kereliuk <kereliuk@chromium.org>
Date: Mon Oct 23 18:58:32 2017

[ChromeDriver] Implementation of Set Window Rect

Will have a follow up CL with integration tests once both this and
Get Window Rect have been merged to master

Bug:  chromedriver:1940 
Change-Id: I07372f234028d4448d973adba29602f6e398cbee
Reviewed-on: https://chromium-review.googlesource.com/687154
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510865}
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/client/command_executor.py
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/3fa9194b35dfc59daf5f453e3c90bc4ddc8ccae3/chrome/test/chromedriver/session_commands.h

Comment 5 by kereliuk@chromium.org, Mar 16 2018

Project Member
Status: Fixed (was: Available)

Comment 6 by bugdroid1@chromium.org, Mar 16 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35d9a7018b2e7ea651518411978e2bd93b46729

commit b35d9a7018b2e7ea651518411978e2bd93b46729
Author: jkereliuk <kereliuk@chromium.org>
Date: Fri Mar 16 04:10:16 2018

[ChromeDriver] Minimize window implementation

This is an implementation of the minimize window endpoint
It uses the Browser.setWindowBounds protocol method

spec: https://w3c.github.io/webdriver/webdriver-spec.html#minimize-window

Bug:  chromedriver:1940 
Change-Id: If5e3394b02f107a254d6be8d8b94a1a7f23b97c7
Reviewed-on: https://chromium-review.googlesource.com/964734
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543615}
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/chrome/chrome_desktop_impl.h
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/client/chromedriver.py
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/client/command_executor.py
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/session_commands.h
[modify] https://crrev.com/b35d9a7018b2e7ea651518411978e2bd93b46729/chrome/test/chromedriver/test/run_py_tests.py

Comment 7 by kereliuk@chromium.org, Mar 16 2018

Project Member
Labels: ChromeDriver-2.37

Sign in to add a comment