New issue
Advanced search Search tips
Starred by 26 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28



Sign in to add a comment
link

Issue 1938: Take element screenshot not implemented in Chromedriver

Reported by kereliuk@chromium.org, Aug 16 2017 Project Member

Issue description

As per spec: https://w3c.github.io/webdriver/webdriver-spec.html#dfn-take-element-screenshot

Take element screenshot is not implemented in Chromedriver. It should use the following endpoint:

GET /session/{session id}/element/{element id}/screenshot
 

Comment 1 by gmanikpure@chromium.org, Aug 18 2017

Project Member
Labels: Pri-2
Status: Available (was: Untriaged)

Comment 2 by m.apelsi...@gmail.com, Jul 4 2018

Hi, is it going to be implemented? Thank you.

Comment 3 by m.tahag...@gmail.com, Jul 29 2018

Is there any progress with this issue ?

Comment 4 by johnchen@chromium.org, Aug 22

Project Member
Labels: StandardsCompliance

Comment 5 by johnchen@chromium.org, Aug 27

Project Member
Owner: buldina@chromium.org
Status: Assigned (was: Available)

Comment 6 by bugdroid1@chromium.org, Aug 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32

commit cc343aac3c8932ecf4e993f9a9a8fef0c7288d32
Author: Tatiana Buldina <buldina@chromium.org>
Date: Tue Aug 28 22:02:51 2018

[ChromeDriver] Implementation of Take Element Screenshot

Also involves changing the function signature and logic a bit
around web_view CaptureScreenshot.

spec: https://w3c.github.io/webdriver/webdriver-spec.html#dfn-take-element-screenshot


(this CL is created based on https://chromium-review.googlesource.com/c/chromium/src/+/984343)

Bug: chromedriver:1938 

Change-Id: Ibd3f57ae3aa71ae65d315a9066d3f2f490887d61
Reviewed-on: https://chromium-review.googlesource.com/1194247
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586877}
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/chrome/stub_web_view.cc
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/chrome/stub_web_view.h
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/chrome/web_view.h
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/chrome/web_view_impl.h
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/client/command_executor.py
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/element_commands.cc
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/chrome/test/chromedriver/window_commands.h
[modify] https://crrev.com/cc343aac3c8932ecf4e993f9a9a8fef0c7288d32/docs/chromedriver_status.md

Comment 7 by buldina@chromium.org, Aug 28

Labels: ToBeReleased ChromeDriver-2.42
Status: Fixed (was: Assigned)

Comment 8 by bugdroid1@chromium.org, Sep 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ea35314d743fbb28b41db8f94261a1fe7b36f06

commit 7ea35314d743fbb28b41db8f94261a1fe7b36f06
Author: John Chen <johnchen@chromium.org>
Date: Wed Sep 12 04:51:59 2018

[ChromeDriver] Minor fixes to Take Element Screenshot

Fixes a few minor issues in the implementation of Take Element
Screenshot command:
* Command display name was identical to whole window screenshot command.
* Command missing in client_replay.py.
* Function declaration was in the wrong header file.

Bug:  chromedriver:1938 
Change-Id: I2f263a150f801a70a32a1e0fca7ca6227e857d64
Reviewed-on: https://chromium-review.googlesource.com/1211245
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590600}
[modify] https://crrev.com/7ea35314d743fbb28b41db8f94261a1fe7b36f06/chrome/test/chromedriver/element_commands.h
[modify] https://crrev.com/7ea35314d743fbb28b41db8f94261a1fe7b36f06/chrome/test/chromedriver/log_replay/client_replay.py
[modify] https://crrev.com/7ea35314d743fbb28b41db8f94261a1fe7b36f06/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/7ea35314d743fbb28b41db8f94261a1fe7b36f06/chrome/test/chromedriver/window_commands.h

Comment 9 by johnchen@chromium.org, Sep 14

Project Member
Labels: -ToBeReleased

Comment 10 by johnchen@chromium.org, Sep 27

Project Member
 Issue 1701  has been merged into this issue.

Sign in to add a comment