New issue
Advanced search Search tips

Issue 1897 link

Starred by 82 users

Issue metadata

Status: Assigned
Owner:
Components:

Blocking:
issue 1996
issue 2536


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Implement Actions API

Project Member Reported by kereliuk@chromium.org, Jul 25 2017

Issue description

Implement the actions API from the webdriver spec: https://w3c.github.io/webdriver/webdriver-spec.html#actions
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31fc584cf5d7400be6e73928ca9d115ff1f1fa5

commit e31fc584cf5d7400be6e73928ca9d115ff1f1fa5
Author: Jonathon Kereliuk <kereliuk@chromium.org>
Date: Tue Jul 25 18:41:41 2017

[Chromedriver] ExecutePerformActions method WIP

implementing actions API
Most of the logic for processing and dispatching is done helper methods
which will be submitted when this lands

Change-Id: I366f2db206de53ac92b3cece58f220f9b6148ba9

BUG=https://bugs.chromium.org/p/chromedriver/issues/detail?id=1897

Change-Id: I366f2db206de53ac92b3cece58f220f9b6148ba9
Reviewed-on: https://chromium-review.googlesource.com/582067
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489386}
[modify] https://crrev.com/e31fc584cf5d7400be6e73928ca9d115ff1f1fa5/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/e31fc584cf5d7400be6e73928ca9d115ff1f1fa5/chrome/test/chromedriver/window_commands.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c

commit 3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c
Author: Jonathon Kereliuk <kereliuk@chromium.org>
Date: Tue Oct 17 18:20:15 2017

Revert "[ChromeDriver] Key type actions for the actions API"

This reverts commit 4bd0cd567ddcdbcae606504a5fbb2c023eb9b4a2.

Reason for revert: broke the windows build, also didn't merge with current master recent enough

Original change's description:
> [ChromeDriver] Key type actions for the actions API
> 
> This CL contains the key type actions. Follow up CLs for tests and
> pointer/pause actions
> 
> spec: https://w3c.github.io/webdriver/webdriver-spec.html#actions
> 
> Bug: chromedriver:1897
> Change-Id: I135df58d97a45494e51a5ac09dfce021f7d094d3
> Reviewed-on: https://chromium-review.googlesource.com/692599
> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508958}

TBR=johnchen@chromium.org,kereliuk@chromium.org

Change-Id: I277dd783cc2a9e3f66615fb42eacabd07dcce71f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromedriver:1897
Reviewed-on: https://chromium-review.googlesource.com/721259
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509434}
[modify] https://crrev.com/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c/chrome/test/chromedriver/chrome/status.cc
[modify] https://crrev.com/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c/chrome/test/chromedriver/chrome/status.h
[modify] https://crrev.com/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c/chrome/test/chromedriver/session.h
[modify] https://crrev.com/3813cdc5d461f3f45465f8e63d1dbc9f1364ed4c/chrome/test/chromedriver/window_commands.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19af337b07eb6fc7ea3a229496b30739f67e620

commit a19af337b07eb6fc7ea3a229496b30739f67e620
Author: Jonathon Kereliuk <kereliuk@chromium.org>
Date: Fri Oct 20 15:01:26 2017

Reland "[ChromeDriver] Key type actions for the actions API"

This is a reland of 4bd0cd567ddcdbcae606504a5fbb2c023eb9b4a2
Original change's description:
> [ChromeDriver] Key type actions for the actions API
>
> This CL contains the key type actions. Follow up CLs for tests and
> pointer/pause actions
>
> spec: https://w3c.github.io/webdriver/webdriver-spec.html#actions
>
> Bug: chromedriver:1897
> Change-Id: I135df58d97a45494e51a5ac09dfce021f7d094d3
> Reviewed-on: https://chromium-review.googlesource.com/692599
> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508958}

Bug: chromedriver:1897
Change-Id: Ic6cc2fe03d8ea41f683563417c471d071bcfa624
Reviewed-on: https://chromium-review.googlesource.com/725522
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510435}
[modify] https://crrev.com/a19af337b07eb6fc7ea3a229496b30739f67e620/chrome/test/chromedriver/chrome/status.cc
[modify] https://crrev.com/a19af337b07eb6fc7ea3a229496b30739f67e620/chrome/test/chromedriver/chrome/status.h
[modify] https://crrev.com/a19af337b07eb6fc7ea3a229496b30739f67e620/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/a19af337b07eb6fc7ea3a229496b30739f67e620/chrome/test/chromedriver/session.h
[modify] https://crrev.com/a19af337b07eb6fc7ea3a229496b30739f67e620/chrome/test/chromedriver/window_commands.cc

Sorry to bother... I was just wondering: has this feature landed yet?
I maintain a Webdriver client https://mercmobily.github.io/best-webdriver/index.html and need to figure out if I should implement workarounds for the actions, or just wait a little bit till this one lands.

Please let me know. I am mainly writing this because looking at the changelog and the code, it *should* handle them. However, I am getting:

StatusCodeError: 404 - {"value":{"error":"unknown command","message":"(Session infochrome=63.0.3239.108)","stacktrace":"#0 0x00000054daec <unknown>\n#1 0x0000004cad83 <unknown>\n#2 0x0000004a9633 <unknown>\n#3 0x0000004a30b8 <unknown>\n#4 0x0000004882cf <unknown>\n#5 0x00000048938d <unknown>\n#6 0x00000055ccff <unknown>\n#7 0x00000055a6b7 <unknown>\n#8 0x00000055abc8 <unknown>\n#9 0x00000055d18a <unknown>\n#10 0x00000056f4c5 <unknown>\n#11 0x00000058ed5d <unknown>\n#12 0x00000058a5dd <unknown>\n#13 0x7fce41bd46da start_thread\n#14 0x7fce401e2d7f clone\n"}}


Hi,

I am working on automation of an Electron application(desktop) using spectron framework. The webdriverio's action commands are not working, the reason being actions is still not supported by Chromedriver. when can we expect actions to work with chromedriver.

Environment:
WebdriverIO version: 4.12.0
chromedriver version: 2.40
Node.js version: 8.11.1
Electron version: 1.8.4
Spectron version: 3.8.0
OS : windows 10

Thanks in advance
Karthik
Hi,

At the risk of posting a comment that boils down to "+1 me too", I'm also working a web application for which the Actions API is critical for testing.  In my case, we have some complex, timing-sensitive user gestures to reproduce in tests and the current API is insufficient because the latency between the test process and the remote web driver adds up when a separate command is required for each step.

Can you give us an idea of how much work this is to implement, or when we can expect it to be completed?  At this point I need to decide whether it's worth the effort to pursue some difficult/ugly workarounds for this.

Thanks!
Project Member

Comment 8 by johnchen@chromium.org, Aug 3

 Issue 2529  has been merged into this issue.
Project Member

Comment 9 by johnchen@chromium.org, Aug 9

Labels: StandardsCompliance
Blocking: 2536
Blocking: 1996
Owner: lanwei@chromium.org
The plan is to work on this in Q4.

Comment 13 Deleted

Comment 14 Deleted

 Issue 2614  has been merged into this issue.

Sign in to add a comment