New issue
Advanced search Search tips
Starred by 44 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018


Show other hotlists

Hotlists containing this issue:
Hotlist-8
Hotlist-1
Hotlist-1
Hotlist-1


Sign in to add a comment

testIFrameWithExtensionsSource is failing on Chrome v60+

Project Member Reported by gmanikpure@chromium.org, May 19 2017

Issue description

======================================================================
ERROR: testIFrameWithExtensionsSource (__main__.ChromeExtensionsCapabilityTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/build/slave/chromedriver_mac_10_6/build/src/chrome/test/chromedriver/test/run_py_tests.py", line 1848, in testIFrameWithExtensionsSource
    driver.SwitchToFrame('testframe')
  File "/b/build/slave/chromedriver_mac_10_6/build/src/chrome/test/chromedriver/test/../client/chromedriver.py", line 307, in SwitchToFrame
    self.ExecuteCommand(Command.SWITCH_TO_FRAME, {'id': id_or_name})
  File "/b/build/slave/chromedriver_mac_10_6/build/src/chrome/test/chromedriver/test/../client/chromedriver.py", line 274, in ExecuteCommand
    response = self._ExecuteCommand(command, params)
  File "/b/build/slave/chromedriver_mac_10_6/build/src/chrome/test/chromedriver/test/../client/chromedriver.py", line 267, in _ExecuteCommand
    raise _ExceptionForLegacyResponse(response)
NoSuchFrame: no such frame: element is not a frame
  (Session info: chrome=60.0.3105.0)
  (Driver info: chromedriver=2.29.461585 (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.2 x86_64)

https://build.chromium.org/p/chromium.chromedriver/builders/Mac%2010.6/builds/13153

This test was introduced in crrev.com/473327 to fix  issue#1777  (background:  issue#1777  started failing on Chrome v58+ due to culprit CL crrev.com/450821 ).

Bisecting to see what caused it to fail again on Chrome 60+ .

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571564116da46b3dcd202f9d03c3de41457a9f46

commit 571564116da46b3dcd202f9d03c3de41457a9f46
Author: gmanikpure <gmanikpure@chromium.org>
Date: Mon May 22 17:01:49 2017

[Chromedriver] Disable testIFrameWithExtensionsSource on HEAD.

BUG= chromedriver:1819 

Review-Url: https://codereview.chromium.org/2892303002
Cr-Commit-Position: refs/heads/master@{#473603}

[modify] https://crrev.com/571564116da46b3dcd202f9d03c3de41457a9f46/chrome/test/chromedriver/test/run_py_tests.py

Project Member

Comment 2 by gmanikpure@chromium.org, May 23 2017

Performed bisect and found the culprit CL : crrev.com/468898

Looks like support for "--force-fieldtrials=SiteIsolationExtensions/Control" Chrome command line switch has been removed in this culprit CL. And hence, the fix crrev.com/473327 no longer works for v60+.


Project Member

Comment 3 by gmanikpure@chromium.org, May 23 2017

From the logs, I see two differences :

1) DEVTOOLS EVENT Page.frameDetached is triggered.

2) DEVTOOLS EVENT DOM.setChildNodes doesn't have "frameId".

Attaching the verbose logs of fail run on v60 and pass run on v58.
Issue1819_Fail.log
20.3 KB View Download
Issue1819_Pass.log
35.2 KB View Download
Project Member

Comment 4 by gmanikpure@chromium.org, May 25 2017

Labels: Pri-1
Status: Available (was: Untriaged)
Hi, 
some time no update. When it can be solved?

Thanks.
Google is now pushing version 61 (this is going on since 59) and we still don't have a solution to this problem. Is there any update? It's very quickly becoming a significant roadblock.
Project Member

Comment 7 by johnchen@chromium.org, Sep 11 2017

Cc: -johnchen@chromium.org
Owner: johnchen@chromium.org
Status: Assigned (was: Available)
Working on it now. Sorry for the delay.
Project Member

Comment 8 by gmanikpure@chromium.org, Sep 14 2017

 Issue 2020  has been merged into this issue.
are there any updates?
Project Member

Comment 10 by johnchen@chromium.org, Oct 5 2017

Stilling working on it. Taking longer than expected.
Brandon dejame en paz y neta q si tebgo algun pedo por tus estafas con mi cuenta neta q ahora si vas a valer verga antes de la fecha fuesta para tu fin. Neta we por las buenas. Te dije q me dejes en paz y ya se de todos los integrantes ntp casi el año jodiendome la vida ven aqui te espero en casa y hablamos las cosas como humanos con educacion y honestidad y la neta ya no me interesas como novio ekis we pero me estas sacando de onda si kieres red de mi casa tdb pero estas jodiendo las pantallas y las pc no creo q las vallas a pagar ya weee es la ultima vez q te lo digo la prox actuare y no sabras de donde va a venir el putaso
Jose enrique vilches garcias alis el brando o brandon o como te pongas
John, can you update us about the progress? 
Can we have an update please? We can't update chrome until this is corrected. We can still only run against chrome 59 and they are now at 62. A fix, hack, work-around, anything would be appreciated.
We are also stuck using Chrome 59 for our testing. A workaround would be greatly appreciated, there has been no update on this issue for 46 days.
+1 I'm also stuck using Chrome 59.

Comment 17 by gnusn...@gmail.com, Dec 13 2017

How often should we be expecting updates? If I'm reading correctly, it looks like it has been 60+ days since we've gotten an update.
Progress update please?
Project Member

Comment 19 by johnchen@chromium.org, Jan 8 2018

Still looking for a way to fix this issue. Unfortunately we don't have an ETA due to the complexity of the issue.
 Issue 2209  has been merged into this issue.
+1 - We're also affected by this inability to run our automation tests on the latest chrome browsers - any new news? 
+1 Please let us know workaround. This "--force-fieldtrials=SiteIsolationExtensions/Control" is not working.
Hi - Is it possible for someone to indicate if there is a plan to fix this issue at some point or not? It would be very helpful to our automation planning to know if we shouldn't rely on this issue being resolved. Thx!
Project Member

Comment 25 by johnchen@chromium.org, Feb 26 2018

We expect the fix in ChromeDriver to be release in a few weeks. The fix will require some changes in Chrome, which is expected in upcoming v66.
Project Member

Comment 26 by johnchen@chromium.org, Feb 28 2018

Labels: ChromeDriver-2.36
Status: Fixed (was: Assigned)
The following change fixes this issue, and will be released in upcoming ChromeDriver 2.36:

commit 69001d48045f7470bc435ce015e438209d7c8cc9
Author: John Chen <johnchen@chromium.org>
Date:   Tue Feb 27 17:50:37 2018 +0000

    [ChromeDriver] Support OOPIF
    
    Add support of OOPIF (out-of-process iFrame) to ChromeDriver
    
    Change-Id: I0b936b21597d8970656029c3110bfe0f61ae9aa8
    Reviewed-on: https://chromium-review.googlesource.com/934145
    Commit-Queue: John Chen <johnchen@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#539493}
Thank you for getting this in. I presume this release will be connected to the Chrome browser version 66. Is that correct?
Project Member

Comment 28 by johnchen@chromium.org, Feb 28 2018

This fix has been verified on Chrome browser version 65 and above.
Nice. Thank you!
that's awesome! waiting for this fix
a8933413@iCloud.com
Great that this is fixed, unfortunately I have a follow up bug

https://bugs.chromium.org/p/chromedriver/issues/detail?id=2303
Status: Verified (was: Fixed)
Status: WontFix (was: Verified)
Status: Verified (was: WontFix)

Sign in to add a comment