New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2011
OS: ----
Priority: Medium
Renderer: ----
Type: Defect



Sign in to add a comment
link

Issue 188: [Enhancement] Adding Wayland typedefs to eglplatform.h

Reported by dnicoara@chromium.org, Jul 27 2011

Issue description

Hi,

I'm working on adding Wayland (http://wayland.freedesktop.org/) support for Chromium. Wayland has its own definitions for EGLNativeDisplayType, EGLNativePixmapType, EGLNativeWindowType defined in EGL/eglplatform.h . I currently have the system includes #ifdef-ed such that they pick up the latest version from mesa (http://cgit.freedesktop.org/mesa/mesa/tree/include/EGL/eglplatform.h). Naturally, the review comment asked if we can update the angle include to contain it. Could we include this change in angle?

Related to chromium code review: http://codereview.chromium.org/7467007/

I've attached a patch with the section I'm interested in.

Thanks,
Daniel Nicoara
 
eglplatform.patch
476 bytes View Download

Comment 1 by dan...@transgaming.com, Jul 28 2011

We can include them, however it would be best if the Wayland definitions were push up into the khronos repository copy of eglplatform.h

Comment 2 by dnicoara@chromium.org, Jul 29 2011

I've asked the Wayland guys about their plans for upstreaming yesterday. I'll post back when I have an answer.

For reference, this is the Wayland mailing list post:
http://lists.freedesktop.org/archives/wayland-devel/2011-July/001240.html

Comment 3 by dnicoara@chromium.org, Jul 29 2011

... and this is the response: http://lists.freedesktop.org/archives/wayland-devel/2011-July/001241.html 

So for now, there are no plans for pushing the changes to Khronos.

Comment 4 by dan...@transgaming.com, Jul 29 2011

Status: Fixed
Ok well I've added them in r709.  (I did refresh the headers from Khronos first though).

Hopefully they push the definitions up to Khronos at some point.  That's the best way to make sure there are no conflicting type definitions.

Comment 5 by csred...@gmail.com, Oct 23 2012

When this done? Released Wayland 1.0!

Sign in to add a comment